Re: [PATCH] kvm: pass value to in_range callback

Gregory Haskins
2009-06-25T19:25:15Z

[-- Attachment #1: Type: text/plain, Size: 1031 bytes --]

Michael S. Tsirkin wrote:
> On Thu, Jun 25, 2009 at 10:49:51AM -0400, Gregory Haskins wrote:
>
>> Michael S. Tsirkin wrote:
>>
>>> For write transactions, pass the value written to in_range checks so
>>> that we can make each iosignalfd a separate device on kvm bus.
>>>
>>> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
>>> ---
>>>
>>> Reposting with a subject now. Sorry.
>>>
>>> Avi, can you please merge this patch in kvm.git so that
>>> Gregory can use it for iosignalfd? Once bus has RCU
>>> we'll be able to remove in_range completely, but
>>> let's do it step by step.
>>>
>>>
>> I think this patch will just make more churn for me, not less. You have
>> now convinced me that your io_range-less approach is better. ;)
>>
>> Lets just fix the RCU thing and do it right. Patch is under development
>> as we speak.
>>
>> -Greg
>>
>
> So - let's go ahead with this one?
>
>

Whatever you think is best and/or gets us to the end goal the fastest ;)