From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joerg Roedel Subject: Re: Problems on AMD laptops Date: Mon, 29 Jun 2009 16:39:15 +0200 Message-ID: <20090629143915.GG4182@8bytes.org> References: <4A48C47D.3070908@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: KVM list To: Avi Kivity Return-path: Received: from 8bytes.org ([88.198.83.132]:50451 "EHLO 8bytes.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759545AbZF2O5E (ORCPT ); Mon, 29 Jun 2009 10:57:04 -0400 Content-Disposition: inline In-Reply-To: <4A48C47D.3070908@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Mon, Jun 29, 2009 at 04:41:17PM +0300, Avi Kivity wrote: > kerneloops.org shows tons of oopses on amd, see > http://www.kerneloops.org/oops.php?number=79008. I suspect this has to > do with resuming a laptop while a guest is running. Can anyone confirm > or deny? I havn't verified this yet but it may have to do with dirty caches that are not written back to memory in suspend-to-ram and are thus lost. The resume code-path looks otherwise sane to me. The only thing I can imagine is that a bit in the cpu_hardware_enabled cpumask is wrong after resume. Btw. it is guaranteed that with cpu-hotplug the cpu isn't already executing processes when the CPU_ONLINE event call chain is called? At least the CPU is marked online and active at that point in time. Joerg