Re: [PATCH v3] enable x2APIC without interrupt remapping under KVM

Eric W. Biederman
2009-06-30T19:43:50Z

Gleb Natapov <gleb@redhat.com> writes:

> Considering that interrupt remapping is fairly new feature
> are you saying that hotplug (pci and cpu) on x86 is a horrible
> hack on Linux?

Just the current cpu hotplug path.

>> It is better than nothing but it certainly is not something
>> I would expect to work all of the time.
>>
> Because of horrible code or non-complaint ioapic implementation out
> there? If later this is not a big issue for KVM.

Both. And even in spec ioapics can't be made to work 100% reliably.

>> Interrupt remapping is the one case where we have hardware
>> that works according to spec and that works reasonably well.
>>
> I am sure when there was only one ioapic implementation in existence
> it worked according to a spec (and if not spec was changed :)) Give
> interrupt remapping some time and than we will see how above statement
> holds.

What we need for cpu hotplug/unplug is on the tested path now.
That is a significant difference.

Eric