From: Ingo Molnar <mingo@elte.hu>
To: Suresh Siddha <suresh.b.siddha@intel.com>
Cc: Gleb Natapov <gleb@redhat.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Sheng Yang <sheng@linux.intel.com>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"avi@redhat.com" <avi@redhat.com>
Subject: Re: [PATCH v5] enable x2APIC without interrupt remapping under KVM
Date: Fri, 3 Jul 2009 10:29:05 +0200 [thread overview]
Message-ID: <20090703082905.GF21833@elte.hu> (raw)
In-Reply-To: <1246482017.27006.10670.camel@localhost.localdomain>
* Suresh Siddha <suresh.b.siddha@intel.com> wrote:
> On Wed, 2009-07-01 at 06:30 -0700, Gleb Natapov wrote:
> > KVM would like to provide x2APIC interface to a guest without emulating
> > interrupt remapping device. The reason KVM prefers guest to use x2APIC
> > is that x2APIC interface is better virtualizable and provides better
> > performance than mmio xAPIC interface:
> >
> > - msr exits are faster than mmio (no page table walk, emulation)
> > - no need to read back ICR to look at the busy bit
> > - one 64 bit ICR write instead of two 32 bit writes
> > - shared code with the Hyper-V paravirt interface
> >
> > Included patch changes x2APIC enabling logic to enable it even if IR
> > initialization failed, but kernel runs under KVM and no apic id is
> > greater than 255 (if there is one spec requires BIOS to move to x2apic
> > mode before starting an OS).
> >
> > Signed-off-by: Gleb Natapov <gleb@redhat.com>
>
> Acked-by: Suresh Siddha <suresh.b.siddha@intel.com>
Now, since this affects core x86 APIC code non-trivially so should
submitted to and go via the x86 tree. (Can prepare a special branch
with just this change if KVM tree wants/needs to pull it before
v2.6.32.)
Ingo
next prev parent reply other threads:[~2009-07-03 8:29 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-01 13:30 [PATCH v5] enable x2APIC without interrupt remapping under KVM Gleb Natapov
2009-07-01 21:00 ` Suresh Siddha
2009-07-03 8:29 ` Ingo Molnar [this message]
2009-07-04 9:35 ` Eric W. Biederman
2009-07-04 9:55 ` Gleb Natapov
2009-07-04 14:33 ` Eric W. Biederman
2009-07-04 15:50 ` Gleb Natapov
2009-07-05 0:22 ` Eric W. Biederman
2009-07-05 5:27 ` Avi Kivity
2009-07-04 15:20 ` Avi Kivity
2009-07-05 14:32 ` [PATCH] " Gleb Natapov
2009-07-10 13:56 ` Ingo Molnar
2009-07-12 12:06 ` Gleb Natapov
2009-07-18 14:07 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090703082905.GF21833@elte.hu \
--to=mingo@elte.hu \
--cc=avi@redhat.com \
--cc=gleb@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sheng@linux.intel.com \
--cc=suresh.b.siddha@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox