From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: Re: [PATCHv4 4/5] qemu/msi: missing braces Date: Sun, 5 Jul 2009 14:56:01 +0300 Message-ID: <20090705115601.GA4826@redhat.com> References: <20090705114057.GE4798@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: qemu-devel@nongnu.org, avi@redhat.com, kvm@vger.kernel.org, aliguori@us.ibm.com, kwolf@redhat.com, glommer@redhat.com To: Blue Swirl Return-path: Received: from mx2.redhat.com ([66.187.237.31]:42163 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751623AbZGEL4k (ORCPT ); Sun, 5 Jul 2009 07:56:40 -0400 Content-Disposition: inline In-Reply-To: Sender: kvm-owner@vger.kernel.org List-ID: On Sun, Jul 05, 2009 at 02:48:12PM +0300, Blue Swirl wrote: > On 7/5/09, Michael S. Tsirkin wrote: > > MSIX present bit is tested incorrectly, and only happens to work because > > the bit we are testing is 0x1. Add braces to fix this. > > > > Reported-by: Blue Swirl > > Signed-off-by: Michael S. Tsirkin > > --- > > hw/msix.c | 2 +- > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > diff --git a/hw/msix.c b/hw/msix.c > > index 33549f5..db72cc3 100644 > > --- a/hw/msix.c > > +++ b/hw/msix.c > > @@ -298,7 +298,7 @@ void msix_load(PCIDevice *dev, QEMUFile *f) > > { > > unsigned n = dev->msix_entries_nr; > > > > - if (!dev->cap_present & QEMU_PCI_CAP_MSIX) > > + if (!(dev->cap_present & QEMU_PCI_CAP_MSIX)) > > With the braces comment I meant that while working on the code, you > should update it to match CODING_STYLE: > if (!(dev->cap_present & QEMU_PCI_CAP_MSIX)) { > return; > } Yea ... it's probably better to do this all over the file, not piecewise, though. No? -- MST