From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: Re: [PATCHv4 4/5] qemu/msi: missing braces Date: Sun, 5 Jul 2009 16:18:50 +0300 Message-ID: <20090705131850.GA5513@redhat.com> References: <20090705114057.GE4798@redhat.com> <20090705115601.GA4826@redhat.com> <4A50976A.8040901@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Blue Swirl , qemu-devel@nongnu.org, kvm@vger.kernel.org, aliguori@us.ibm.com, kwolf@redhat.com, glommer@redhat.com To: Avi Kivity Return-path: Received: from mx2.redhat.com ([66.187.237.31]:53731 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752126AbZGENTa (ORCPT ); Sun, 5 Jul 2009 09:19:30 -0400 Content-Disposition: inline In-Reply-To: <4A50976A.8040901@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Sun, Jul 05, 2009 at 03:07:06PM +0300, Avi Kivity wrote: > On 07/05/2009 02:56 PM, Michael S. Tsirkin wrote: >>> With the braces comment I meant that while working on the code, you >>> should update it to match CODING_STYLE: >>> if (!(dev->cap_present& QEMU_PCI_CAP_MSIX)) { >>> return; >>> } >>> >> >> Yea ... it's probably better to do this all over the file, not piecewise, >> though. No? >> > > No, that just causes churn (and merge conflicts for me). Better to only > fix if you have a patch that modifies the same place. OK, I redid these patches with {}. Even though the kernel style is better! ;) -- MST