* [PATCH] kvm: fail msi request if !level
@ 2009-07-05 18:27 Michael S. Tsirkin
2009-07-07 11:24 ` Avi Kivity
0 siblings, 1 reply; 2+ messages in thread
From: Michael S. Tsirkin @ 2009-07-05 18:27 UTC (permalink / raw)
To: avi, kvm
Irqfd sets level for interrupt to 1 and then to 0.
For MSI, check level so that a single message is sent.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
virt/kvm/irq_comm.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/virt/kvm/irq_comm.c b/virt/kvm/irq_comm.c
index c380bf0..7af18b8 100644
--- a/virt/kvm/irq_comm.c
+++ b/virt/kvm/irq_comm.c
@@ -139,7 +139,9 @@ int kvm_set_irq(struct kvm *kvm, int irq_source_id, int irq, int level)
else
clear_bit(irq_source_id, irq_state);
sig_level = !!(*irq_state);
- } else /* Deal with MSI/MSI-X */
+ } else if (!level)
+ return ret;
+ else /* Deal with MSI/MSI-X */
sig_level = 1;
/* Not possible to detect if the guest uses the PIC or the
--
1.6.2.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] kvm: fail msi request if !level
2009-07-05 18:27 [PATCH] kvm: fail msi request if !level Michael S. Tsirkin
@ 2009-07-07 11:24 ` Avi Kivity
0 siblings, 0 replies; 2+ messages in thread
From: Avi Kivity @ 2009-07-07 11:24 UTC (permalink / raw)
To: Michael S. Tsirkin; +Cc: kvm
On 07/05/2009 09:27 PM, Michael S. Tsirkin wrote:
> Irqfd sets level for interrupt to 1 and then to 0.
> For MSI, check level so that a single message is sent.
>
Applied, thanks.
--
error compiling committee.c: too many arguments to function
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-07-07 11:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-07-05 18:27 [PATCH] kvm: fail msi request if !level Michael S. Tsirkin
2009-07-07 11:24 ` Avi Kivity
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox