From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gleb Natapov Subject: Re: [PATCH 3/8] put qemu-kvm-x86.c into kvm.c Date: Wed, 8 Jul 2009 16:28:51 +0300 Message-ID: <20090708132851.GN28046@redhat.com> References: <1247058542-31211-1-git-send-email-glommer@redhat.com> <1247058542-31211-2-git-send-email-glommer@redhat.com> <1247058542-31211-3-git-send-email-glommer@redhat.com> <1247058542-31211-4-git-send-email-glommer@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: kvm@vger.kernel.org, avi@redhat.com To: Glauber Costa Return-path: Received: from mx2.redhat.com ([66.187.237.31]:59947 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753484AbZGHN2z (ORCPT ); Wed, 8 Jul 2009 09:28:55 -0400 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n68DSsw8001253 for ; Wed, 8 Jul 2009 09:28:54 -0400 Content-Disposition: inline In-Reply-To: <1247058542-31211-4-git-send-email-glommer@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Wed, Jul 08, 2009 at 09:08:57AM -0400, Glauber Costa wrote: > big plan to start sharing code with upstream. > It is hard enough (for me at least) to distinguish between upstream code and qemu-kvm when I have to look at the code. Having them separated in different files is very helpful. Looking at the filename in a grep result is enough to know if I should care about the result or not. Can you simple include qemu-kvm-x86.c into kvm.c? -- Gleb.