From mboxrd@z Thu Jan  1 00:00:00 1970
From: Christoph Hellwig <hch@lst.de>
Subject: Re: [Qemu-devel] [PATCH -v6] QEMU: MCE: Add MCE simulation to qemu/tcg
Date: Fri, 10 Jul 2009 20:30:19 +0200
Message-ID: <20090710183019.GB8725@lst.de>
References: <1245722714.22246.424.camel@yhuang-dev.sh.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Avi Kivity <avi@redhat.com>,
	Anthony Liguori <anthony@codemonkey.ws>,
	Andi Kleen <andi@firstfloor.org>, qemu-devel@nongnu.org,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>
To: Huang Ying <ying.huang@intel.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from verein.lst.de ([213.95.11.210]:43494 "EHLO verein.lst.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1753916AbZGJSah (ORCPT <rfc822;kvm@vger.kernel.org>);
	Fri, 10 Jul 2009 14:30:37 -0400
Content-Disposition: inline
In-Reply-To: <1245722714.22246.424.camel@yhuang-dev.sh.intel.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Tue, Jun 23, 2009 at 10:05:14AM +0800, Huang Ying wrote:
> - MCE features are initialized when VCPU is intialized according to CPUID.
> - A monitor command "mce" is added to inject a MCE.
> - A new interrupt mask: CPU_INTERRUPT_MCE is added to inject the MCE.

This patch (now in the qemu tree) breaks compilation for me on i386:

/home/hch/work/qemu/target-i386/helper.c: In function
'cpu_inject_x86_mce':
/home/hch/work/qemu/target-i386/helper.c:1510: error: left shift count >= width of type
/home/hch/work/qemu/target-i386/helper.c:1517: error: left shift count >= width of type
/home/hch/work/qemu/target-i386/helper.c:1525: error: left shift count >= width of type
/home/hch/work/qemu/target-i386/helper.c:1527: error: left shift count >= width of type
/home/hch/work/qemu/target-i386/helper.c:1536: error: left shift count >= width of type
/home/hch/work/qemu/target-i386/helper.c:1537: error: left shift count >= width of type
/home/hch/work/qemu/target-i386/helper.c:1543: error: left shift count >= width of type
/home/hch/work/qemu/target-i386/helper.c:1545: error: left shift count >= width of type
/home/hch/work/qemu/target-i386/helper.c:1546: error: left shift count >= width of type
/home/hch/work/qemu/target-i386/helper.c:1551: error: left shift count >= width of type