Re: [PATCH] Reduce interface between kvm general and kvm arch.

[Gleb Natapov <gleb@redhat.com>]

On Sun, Jul 12, 2009 at 02:03:17PM +0300, Avi Kivity wrote:
> On 07/09/2009 03:33 PM, Gleb Natapov wrote:
>>
>> diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c
>> index 05b6bc7..cf20dc1 100644
>> --- a/virt/kvm/kvm_main.c
>> +++ b/virt/kvm/kvm_main.c
>> @@ -1666,9 +1666,7 @@ void kvm_vcpu_block(struct kvm_vcpu *vcpu)
>>   	for (;;) {
>>   		prepare_to_wait(&vcpu->wq,&wait, TASK_INTERRUPTIBLE);
>>
>> -		if ((kvm_arch_interrupt_allowed(vcpu)&&
>> -					kvm_cpu_has_interrupt(vcpu)) ||
>> -				kvm_arch_vcpu_runnable(vcpu)) {
>> +		if (kvm_arch_vcpu_runnable(vcpu)) {
>>   			set_bit(KVM_REQ_UNHALT,&vcpu->requests);
>>   			break;
>>   		}
>>    
>
> s390 has:
>
>
> int kvm_arch_vcpu_runnable(struct kvm_vcpu *vcpu)
> {
>     /* kvm common code refers to this, but never calls it */
>     BUG();
>     return 0;
> }
>
> So this needs to be updated.  Please coordinate with the s390 folks.
>
s390 never calls kvm_vcpu_block(). They implement their own blocking.

--
			Gleb.