From mboxrd@z Thu Jan  1 00:00:00 1970
From: Gleb Natapov <gleb@redhat.com>
Subject: Re: [PATCH] Reduce interface between kvm general and kvm arch.
Date: Sun, 12 Jul 2009 14:02:24 +0300
Message-ID: <20090712110224.GZ28046@redhat.com>
References: <1247142834-16993-2-git-send-email-gleb@redhat.com> <4A59C2F5.4080102@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: kvm@vger.kernel.org
To: Avi Kivity <avi@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx2.redhat.com ([66.187.237.31]:42318 "EHLO mx2.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751656AbZGLLC0 (ORCPT <rfc822;kvm@vger.kernel.org>);
	Sun, 12 Jul 2009 07:02:26 -0400
Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26])
	by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n6CB2QDG015013
	for <kvm@vger.kernel.org>; Sun, 12 Jul 2009 07:02:26 -0400
Content-Disposition: inline
In-Reply-To: <4A59C2F5.4080102@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Sun, Jul 12, 2009 at 02:03:17PM +0300, Avi Kivity wrote:
> On 07/09/2009 03:33 PM, Gleb Natapov wrote:
>>
>> diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c
>> index 05b6bc7..cf20dc1 100644
>> --- a/virt/kvm/kvm_main.c
>> +++ b/virt/kvm/kvm_main.c
>> @@ -1666,9 +1666,7 @@ void kvm_vcpu_block(struct kvm_vcpu *vcpu)
>>   	for (;;) {
>>   		prepare_to_wait(&vcpu->wq,&wait, TASK_INTERRUPTIBLE);
>>
>> -		if ((kvm_arch_interrupt_allowed(vcpu)&&
>> -					kvm_cpu_has_interrupt(vcpu)) ||
>> -				kvm_arch_vcpu_runnable(vcpu)) {
>> +		if (kvm_arch_vcpu_runnable(vcpu)) {
>>   			set_bit(KVM_REQ_UNHALT,&vcpu->requests);
>>   			break;
>>   		}
>>    
>
> s390 has:
>
>
> int kvm_arch_vcpu_runnable(struct kvm_vcpu *vcpu)
> {
>     /* kvm common code refers to this, but never calls it */
>     BUG();
>     return 0;
> }
>
> So this needs to be updated.  Please coordinate with the s390 folks.
>
s390 never calls kvm_vcpu_block(). They implement their own blocking.

--
			Gleb.