From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: Re: [PATCH 1/4] Move irq routing data structure to rcu locking Date: Mon, 13 Jul 2009 16:36:01 +0300 Message-ID: <20090713133601.GF10402@redhat.com> References: <1247400233-24243-1-git-send-email-gleb@redhat.com> <1247400233-24243-2-git-send-email-gleb@redhat.com> <20090713125507.GA10402@redhat.com> <20090713130310.GG28046@redhat.com> <20090713131530.GD10402@redhat.com> <20090713132349.GK28046@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: avi@redhat.com, kvm@vger.kernel.org To: Gleb Natapov Return-path: Received: from mx2.redhat.com ([66.187.237.31]:42923 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755758AbZGMNgs (ORCPT ); Mon, 13 Jul 2009 09:36:48 -0400 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n6DDamvw013437 for ; Mon, 13 Jul 2009 09:36:48 -0400 Content-Disposition: inline In-Reply-To: <20090713132349.GK28046@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Mon, Jul 13, 2009 at 04:23:49PM +0300, Gleb Natapov wrote: > > resource. Maybe it's a good idea to use an array instead of a list. All > > I'm saying, RCU does not force you to do this. > > > It doesn't, but list shouldn't be used here in the first place. OK, but I think the change and the reason for it should be documented in the patch subject and description. -- MST