From: Marcelo Tosatti <mtosatti@redhat.com>
To: Sheng Yang <sheng@linux.intel.com>
Cc: kvm@vger.kernel.org, Avi Kivity <avi@redhat.com>
Subject: Re: [PATCH] KVM: Discard unnecessary kvm_mmu_flush_tlb() in kvm_mmu_load()
Date: Mon, 13 Jul 2009 10:51:08 -0300 [thread overview]
Message-ID: <20090713135108.GA3850@amt.cnet> (raw)
In-Reply-To: <200907131942.57330.sheng@linux.intel.com>
On Mon, Jul 13, 2009 at 07:42:56PM +0800, Sheng Yang wrote:
> On Thursday 09 July 2009 17:00:42 Sheng Yang wrote:
> > set_cr3() should already cover the TLB flushing.
> >
> Comments?
Looks good.
>
> --
> regards
> Yang, Sheng
>
> > Signed-off-by: Sheng Yang <sheng@linux.intel.com>
> > ---
> > arch/x86/kvm/mmu.c | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/arch/x86/kvm/mmu.c b/arch/x86/kvm/mmu.c
> > index 231d880..501c11e 100644
> > --- a/arch/x86/kvm/mmu.c
> > +++ b/arch/x86/kvm/mmu.c
> > @@ -2349,8 +2349,8 @@ int kvm_mmu_load(struct kvm_vcpu *vcpu)
> > spin_unlock(&vcpu->kvm->mmu_lock);
> > if (r)
> > goto out;
> > + /* set_cr3() should ensure TLB has been flushed */
> > kvm_x86_ops->set_cr3(vcpu, vcpu->arch.mmu.root_hpa);
> > - kvm_mmu_flush_tlb(vcpu);
> > out:
> > return r;
> > }
>
next prev parent reply other threads:[~2009-07-13 13:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-09 9:00 [PATCH] KVM: Discard unnecessary kvm_mmu_flush_tlb() in kvm_mmu_load() Sheng Yang
2009-07-13 11:42 ` Sheng Yang
2009-07-13 13:51 ` Marcelo Tosatti [this message]
2009-07-13 12:23 ` Avi Kivity
2009-07-13 13:29 ` Sheng Yang
2009-07-15 19:04 ` Marcelo Tosatti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090713135108.GA3850@amt.cnet \
--to=mtosatti@redhat.com \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=sheng@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox