From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marcelo Tosatti <mtosatti@redhat.com>
Subject: Re: [PATCH] KVM: Discard unnecessary kvm_mmu_flush_tlb() in
	kvm_mmu_load()
Date: Mon, 13 Jul 2009 10:51:08 -0300
Message-ID: <20090713135108.GA3850@amt.cnet>
References: <1247130042-32290-1-git-send-email-sheng@linux.intel.com> <200907131942.57330.sheng@linux.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: kvm@vger.kernel.org, Avi Kivity <avi@redhat.com>
To: Sheng Yang <sheng@linux.intel.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx2.redhat.com ([66.187.237.31]:42824 "EHLO mx2.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1755862AbZGMNvz (ORCPT <rfc822;kvm@vger.kernel.org>);
	Mon, 13 Jul 2009 09:51:55 -0400
Content-Disposition: inline
In-Reply-To: <200907131942.57330.sheng@linux.intel.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Mon, Jul 13, 2009 at 07:42:56PM +0800, Sheng Yang wrote:
> On Thursday 09 July 2009 17:00:42 Sheng Yang wrote:
> > set_cr3() should already cover the TLB flushing.
> >
> Comments?

Looks good.

> 
> -- 
> regards
> Yang, Sheng
> 
> > Signed-off-by: Sheng Yang <sheng@linux.intel.com>
> > ---
> >  arch/x86/kvm/mmu.c |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/arch/x86/kvm/mmu.c b/arch/x86/kvm/mmu.c
> > index 231d880..501c11e 100644
> > --- a/arch/x86/kvm/mmu.c
> > +++ b/arch/x86/kvm/mmu.c
> > @@ -2349,8 +2349,8 @@ int kvm_mmu_load(struct kvm_vcpu *vcpu)
> >  	spin_unlock(&vcpu->kvm->mmu_lock);
> >  	if (r)
> >  		goto out;
> > +	/* set_cr3() should ensure TLB has been flushed */
> >  	kvm_x86_ops->set_cr3(vcpu, vcpu->arch.mmu.root_hpa);
> > -	kvm_mmu_flush_tlb(vcpu);
> >  out:
> >  	return r;
> >  }
>