Re: [PATCHv3 RFC] uio: add generic driver for PCI 2.3 devices

Michael S. Tsirkin
2009-07-14T18:49:39Z

On Tue, Jul 14, 2009 at 11:03:38AM -0700, Chris Wright wrote:
> * Michael S. Tsirkin (mst@redhat.com) wrote:
> > - remove irqcontrol: user can enable interrupts by
> > writing command register directly
>
> Sorry if I gave you the impression that removing was needed.
> I actually think the irqcontrol was useful since it's atomic.

What I'm saying, it is not strictly needed (user can safely write 0 in
that register and worst case you just get an extra interrupt). So let's
make the decision on what does irqcontrol do when we have a pressing
need for an extra kernel/user interface.

> > + gdev->info.name = "uio_pci_generic";
> > + gdev->info.version = "0.01";
>
> Minor nit: DRIVER_VERSION

Ack.

> Otherwise, it looks good.
>
> thanks,
>
> -chris

Thanks!