From: Gleb Natapov <gleb@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: kvm@vger.kernel.org, avi@redhat.com, mtosatti@redhat.com
Subject: Re: [PATCH 3/5] Move irq notifiers lists to its own locking.
Date: Mon, 13 Jul 2009 19:28:07 +0300 [thread overview]
Message-ID: <20090713162807.GB7438@redhat.com> (raw)
In-Reply-To: <20090713154007.GA10651@redhat.com>
On Mon, Jul 13, 2009 at 06:40:07PM +0300, Michael S. Tsirkin wrote:
> On Mon, Jul 13, 2009 at 06:23:11PM +0300, Gleb Natapov wrote:
> > > So, to summarize: this patch does not help speed irq injection up, the
> > > only reason to change locking here is cosmetical. Is this a fair
> > > summary?
> > >
> > The whole series helps to speed irq injection up. This patch is one step
> > towards the goal.
>
> Let me rephrase: it's possible to drop patches 2 and 3 from the series
> and irq injection will still be lockless. Correct?
>
You can use here any one of million locks that is available in linux
that is not taken at the moment this functions are called. So yes you
can drop them.
--
Gleb.
next prev parent reply other threads:[~2009-07-13 16:28 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-13 9:12 [PATCH 0/5][RFC] more fine grained locking for IRQ injection Gleb Natapov
2009-07-13 9:12 ` [PATCH 1/5] Protect irq_sources_bitmap by kvm->lock instead of kvm->irq_lock Gleb Natapov
2009-07-13 14:29 ` Gregory Haskins
2009-07-13 14:39 ` Gleb Natapov
2009-07-13 14:55 ` Michael S. Tsirkin
2009-07-13 15:01 ` Gleb Natapov
2009-07-13 15:03 ` Gregory Haskins
2009-07-13 15:11 ` Gregory Haskins
2009-07-13 15:19 ` Gleb Natapov
2009-07-13 9:12 ` [PATCH 2/5] Move irq routing to its own locking Gleb Natapov
2009-07-13 9:12 ` [PATCH 3/5] Move irq notifiers lists " Gleb Natapov
2009-07-13 11:45 ` Michael S. Tsirkin
2009-07-13 11:48 ` Gleb Natapov
2009-07-13 14:23 ` Michael S. Tsirkin
2009-07-13 14:37 ` Gleb Natapov
2009-07-13 14:49 ` Michael S. Tsirkin
2009-07-13 15:23 ` Gleb Natapov
2009-07-13 15:32 ` Gregory Haskins
2009-07-13 15:40 ` Michael S. Tsirkin
2009-07-13 16:28 ` Gleb Natapov [this message]
2009-07-13 16:23 ` Marcelo Tosatti
2009-07-13 16:31 ` Marcelo Tosatti
2009-07-13 16:35 ` Gleb Natapov
2009-07-13 16:43 ` Marcelo Tosatti
2009-07-13 9:12 ` [PATCH 4/5] Move IO APIC to its own lock Gleb Natapov
2009-07-13 9:12 ` [PATCH 5/5] Drop kvm->irq_lock lock Gleb Natapov
2009-07-13 13:23 ` [PATCH 0/5][RFC] more fine grained locking for IRQ injection Michael S. Tsirkin
2009-07-13 13:28 ` Gleb Natapov
2009-07-13 13:53 ` Michael S. Tsirkin
2009-07-13 13:58 ` Gleb Natapov
2009-07-13 14:21 ` Michael S. Tsirkin
2009-07-13 14:33 ` Gleb Natapov
2009-07-13 14:43 ` Michael S. Tsirkin
2009-07-13 15:21 ` Gleb Natapov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090713162807.GB7438@redhat.com \
--to=gleb@redhat.com \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mst@redhat.com \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox