From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gleb Natapov Subject: Re: [PATCH 3/5] Move irq notifiers lists to its own locking. Date: Mon, 13 Jul 2009 19:28:07 +0300 Message-ID: <20090713162807.GB7438@redhat.com> References: <1247476355-27284-1-git-send-email-gleb@redhat.com> <1247476355-27284-4-git-send-email-gleb@redhat.com> <20090713114550.GA10387@redhat.com> <20090713114844.GF28046@redhat.com> <20090713142320.GJ10402@redhat.com> <20090713143750.GS28046@redhat.com> <20090713144920.GL10402@redhat.com> <20090713152311.GN23086@redhat.com> <20090713154007.GA10651@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: kvm@vger.kernel.org, avi@redhat.com, mtosatti@redhat.com To: "Michael S. Tsirkin" Return-path: Received: from mx2.redhat.com ([66.187.237.31]:33417 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755755AbZGMQ2K (ORCPT ); Mon, 13 Jul 2009 12:28:10 -0400 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n6DGS9W2000757 for ; Mon, 13 Jul 2009 12:28:09 -0400 Content-Disposition: inline In-Reply-To: <20090713154007.GA10651@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Mon, Jul 13, 2009 at 06:40:07PM +0300, Michael S. Tsirkin wrote: > On Mon, Jul 13, 2009 at 06:23:11PM +0300, Gleb Natapov wrote: > > > So, to summarize: this patch does not help speed irq injection up, the > > > only reason to change locking here is cosmetical. Is this a fair > > > summary? > > > > > The whole series helps to speed irq injection up. This patch is one step > > towards the goal. > > Let me rephrase: it's possible to drop patches 2 and 3 from the series > and irq injection will still be lockless. Correct? > You can use here any one of million locks that is available in linux that is not taken at the moment this functions are called. So yes you can drop them. -- Gleb.