From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gleb Natapov Subject: Re: [PATCH 3/5] Move irq notifiers lists to its own locking. Date: Mon, 13 Jul 2009 19:35:41 +0300 Message-ID: <20090713163541.GA8356@redhat.com> References: <1247476355-27284-1-git-send-email-gleb@redhat.com> <1247476355-27284-4-git-send-email-gleb@redhat.com> <20090713114550.GA10387@redhat.com> <20090713114844.GF28046@redhat.com> <20090713142320.GJ10402@redhat.com> <20090713143750.GS28046@redhat.com> <20090713162338.GA7713@amt.cnet> <20090713163106.GA7920@amt.cnet> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: "Michael S. Tsirkin" , kvm@vger.kernel.org, avi@redhat.com To: Marcelo Tosatti Return-path: Received: from mx2.redhat.com ([66.187.237.31]:38191 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756411AbZGMQfo (ORCPT ); Mon, 13 Jul 2009 12:35:44 -0400 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n6DGZihu002691 for ; Mon, 13 Jul 2009 12:35:44 -0400 Content-Disposition: inline In-Reply-To: <20090713163106.GA7920@amt.cnet> Sender: kvm-owner@vger.kernel.org List-ID: On Mon, Jul 13, 2009 at 01:31:06PM -0300, Marcelo Tosatti wrote: > > slots_lock is just a bad name now. See slots_lock is taken for read on > > every exit. So taking slots_lock for write means all guests are stopped > ^^^^^^ > > all vcpus > That is a very good reason to not wanting slots_lock near interrupt injection path. -- Gleb.