From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gleb Natapov Subject: Re: [PATCH 1/4] Move irq routing data structure to rcu locking Date: Mon, 13 Jul 2009 19:54:37 +0300 Message-ID: <20090713165437.GC8356@redhat.com> References: <1247400233-24243-2-git-send-email-gleb@redhat.com> <4A5B302D.2040802@novell.com> <20090713131534.GJ28046@redhat.com> <20090713155531.GA7520@amt.cnet> <20090713162453.GA7438@redhat.com> <20090713162738.GA7886@amt.cnet> <20090713163330.GC7438@redhat.com> <20090713164213.GA7966@amt.cnet> <20090713164438.GB8356@redhat.com> <20090713164507.GA7990@amt.cnet> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Gregory Haskins , avi@redhat.com, kvm@vger.kernel.org To: Marcelo Tosatti Return-path: Received: from mx2.redhat.com ([66.187.237.31]:49367 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753387AbZGMQyk (ORCPT ); Mon, 13 Jul 2009 12:54:40 -0400 Content-Disposition: inline In-Reply-To: <20090713164507.GA7990@amt.cnet> Sender: kvm-owner@vger.kernel.org List-ID: On Mon, Jul 13, 2009 at 01:45:07PM -0300, Marcelo Tosatti wrote: > On Mon, Jul 13, 2009 at 07:44:38PM +0300, Gleb Natapov wrote: > > > > I don't get it. The point for RCU is to get rid of reader's lock. If > > > > I'll have to take slot_lock on each EOI I achieved nothing. > > > > > > You already take slots_lock for read on every exit. > > > > > We should fix that, not add even more users. Shouldn't we? > > Yes. Please send both patchsets as one when you resend then, its easier > to review. OK. -- Gleb.