public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: Gleb Natapov <gleb@redhat.com>
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
	Gregory Haskins <gregory.haskins@gmail.com>,
	avi@redhat.com, "kvm@vger.kernel.org" <kvm@vger.kernel.org>
Subject: Re: [PATCH 4/4] Convert irq notifiers lists to RCU locking.
Date: Tue, 14 Jul 2009 05:03:09 -0700	[thread overview]
Message-ID: <20090714120309.GA6671@linux.vnet.ibm.com> (raw)
In-Reply-To: <20090714054612.GU28046@redhat.com>

On Tue, Jul 14, 2009 at 08:46:12AM +0300, Gleb Natapov wrote:
> On Mon, Jul 13, 2009 at 12:31:39PM -0700, Paul E. McKenney wrote:
> > On Mon, Jul 13, 2009 at 04:40:59PM +0300, Michael S. Tsirkin wrote:
> > > On Mon, Jul 13, 2009 at 04:32:34PM +0300, Gleb Natapov wrote:
> > > > Yeah I understand that other RCU read section may introduce delays too.
> > > > The question is how big the delay may be.
> > > 
> > > I recall seeing the number "at least 3 jiffies" somewhere, but that
> > > might have changed since.
> > 
> > A grace period lasts a handful of jiffies, depending on kernel
> > configuration and how long readers remain in a given RCU read-side
> > critical section.
> > 
> > If a handful of jiffies is too long, there are patches that speed up
> > the grace period, down into the sub-hundred-microsecond range.
> > 
> > > > I don't think multiple
> > > > milliseconds delay in device de-assignment is a big issue though.
> > > 
> > > Right. My point was that since the sync is done under kvm lock, the
> > > guest can easily get blocked trying to get kvm lock meanwhile.
> > 
> > I will ask the usual question -- can call_rcu() be used to move
> > the grace period out from under the lock?  (Often this can be done,
> > but not always.)
> > 
> It can't. Caller frees the data.

I will then ask the usual next question...  Can the freeing of the
data be moved from the caller?

						Thanx, Paul

  reply	other threads:[~2009-07-14 12:03 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-12 12:03 [PATCH 0/4] moving irq routing and notifiers to RCU locking Gleb Natapov
2009-07-12 12:03 ` [PATCH 1/4] Move irq routing data structure to rcu locking Gleb Natapov
2009-07-13 12:55   ` Michael S. Tsirkin
2009-07-13 13:03     ` Gleb Natapov
2009-07-13 13:15       ` Michael S. Tsirkin
2009-07-13 13:23         ` Gleb Natapov
2009-07-13 13:36           ` Michael S. Tsirkin
2009-07-13 13:01   ` Gregory Haskins
2009-07-13 13:15     ` Gleb Natapov
2009-07-13 13:16       ` Gregory Haskins
2009-07-13 13:25         ` Gleb Natapov
2009-07-13 13:29           ` Gregory Haskins
2009-07-13 15:55       ` Marcelo Tosatti
2009-07-13 16:24         ` Gleb Natapov
2009-07-13 16:27           ` Marcelo Tosatti
2009-07-13 16:33             ` Gleb Natapov
2009-07-13 16:42               ` Marcelo Tosatti
2009-07-13 16:44                 ` Gleb Natapov
2009-07-13 16:45                   ` Marcelo Tosatti
2009-07-13 16:54                     ` Gleb Natapov
2009-07-12 12:03 ` [PATCH 2/4] Unregister ack notifier callback on PIT freeing Gleb Natapov
2009-07-12 12:03 ` [PATCH 3/4] Move irq ack notifier list to arch independent code Gleb Natapov
2009-07-12 12:03 ` [PATCH 4/4] Convert irq notifiers lists to RCU locking Gleb Natapov
2009-07-13 12:56   ` Michael S. Tsirkin
2009-07-13 13:05     ` Gleb Natapov
2009-07-13 13:29       ` Michael S. Tsirkin
2009-07-13 13:48     ` Gregory Haskins
2009-07-13 13:02   ` Michael S. Tsirkin
2009-07-13 13:11     ` Gleb Natapov
2009-07-13 13:26       ` Gregory Haskins
2009-07-13 13:32         ` Gleb Natapov
2009-07-13 13:40           ` Gregory Haskins
2009-07-13 13:52             ` Gleb Natapov
2009-07-13 14:02               ` Gregory Haskins
2009-07-13 14:08                 ` Gleb Natapov
2009-07-13 13:40           ` Michael S. Tsirkin
2009-07-13 13:44             ` Gregory Haskins
2009-07-13 19:31             ` Paul E. McKenney
2009-07-14  5:46               ` Gleb Natapov
2009-07-14 12:03                 ` Paul E. McKenney [this message]
2009-07-14 12:06                   ` Gleb Natapov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090714120309.GA6671@linux.vnet.ibm.com \
    --to=paulmck@linux.vnet.ibm.com \
    --cc=avi@redhat.com \
    --cc=gleb@redhat.com \
    --cc=gregory.haskins@gmail.com \
    --cc=kvm@vger.kernel.org \
    --cc=mst@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox