From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [PATCHv3 RFC] uio: add generic driver for PCI 2.3 devices
Date: Tue, 14 Jul 2009 21:48:51 +0300
Message-ID: <20090714184850.GA16885@redhat.com>
References: <20090713161606.GA10804@redhat.com> <20090714180338.GH25507@x200.localdomain>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: anthony@codemonkey.ws, avi@redhat.com, kvm@vger.kernel.org
To: Chris Wright <chrisw@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx2.redhat.com ([66.187.237.31]:40501 "EHLO mx2.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1755023AbZGNStj (ORCPT <rfc822;kvm@vger.kernel.org>);
	Tue, 14 Jul 2009 14:49:39 -0400
Content-Disposition: inline
In-Reply-To: <20090714180338.GH25507@x200.localdomain>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Tue, Jul 14, 2009 at 11:03:38AM -0700, Chris Wright wrote:
> * Michael S. Tsirkin (mst@redhat.com) wrote:
> > - remove irqcontrol: user can enable interrupts by
> >   writing command register directly
> 
> Sorry if I gave you the impression that removing was needed.
> I actually think the irqcontrol was useful since it's atomic.

What I'm saying, it is not strictly needed (user can safely write 0 in
that register and worst case you just get an extra interrupt).  So let's
make the decision on what does irqcontrol do when we have a pressing
need for an extra kernel/user interface.

> > +	gdev->info.name = "uio_pci_generic";
> > +	gdev->info.version = "0.01";
> 
> Minor nit: DRIVER_VERSION

Ack.

> Otherwise, it looks good.
> 
> thanks,
> 
> -chris

Thanks!