From mboxrd@z Thu Jan 1 00:00:00 1970 From: Glauber Costa Subject: Re: [PATCH v3 8/8] reuse upstream breakpoint code Date: Tue, 14 Jul 2009 18:01:48 -0300 Message-ID: <20090714210148.GF9432@poweredge.glommer> References: <1247585718-32738-1-git-send-email-glommer@redhat.com> <1247585718-32738-2-git-send-email-glommer@redhat.com> <1247585718-32738-3-git-send-email-glommer@redhat.com> <1247585718-32738-4-git-send-email-glommer@redhat.com> <1247585718-32738-5-git-send-email-glommer@redhat.com> <1247585718-32738-6-git-send-email-glommer@redhat.com> <1247585718-32738-7-git-send-email-glommer@redhat.com> <1247585718-32738-8-git-send-email-glommer@redhat.com> <1247585718-32738-9-git-send-email-glommer@redhat.com> <4A5CEE62.6040804@web.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: kvm@vger.kernel.org, avi@redhat.com To: Jan Kiszka Return-path: Received: from mx2.redhat.com ([66.187.237.31]:35790 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752597AbZGNUy7 (ORCPT ); Tue, 14 Jul 2009 16:54:59 -0400 Content-Disposition: inline In-Reply-To: <4A5CEE62.6040804@web.de> Sender: kvm-owner@vger.kernel.org List-ID: On Tue, Jul 14, 2009 at 10:45:22PM +0200, Jan Kiszka wrote: > Glauber Costa wrote: > > Drop KVM_UPSTREAM around functions we intend to reuse. > > This allow us to share code in kvm-all.c, that is equal in qemu-kvm.c > > > > Signed-off-by: Glauber Costa > > CC: Jan Kiszka > > Looks good (and demonstrates nicely how we can merge things in the ideal > case). neat. As per gleb suggestion, I also posted to qemu a patch that gives us on_vcpu(). We can share more code, once it is there. Marcelo, can you please merge it?