From: Marcelo Tosatti <mtosatti@redhat.com>
To: Glauber Costa <glommer@redhat.com>
Cc: Jan Kiszka <jan.kiszka@web.de>, kvm@vger.kernel.org, avi@redhat.com
Subject: Re: [PATCH v3 8/8] reuse upstream breakpoint code
Date: Tue, 14 Jul 2009 18:31:21 -0300 [thread overview]
Message-ID: <20090714213121.GA10465@amt.cnet> (raw)
In-Reply-To: <20090714210148.GF9432@poweredge.glommer>
On Tue, Jul 14, 2009 at 06:01:48PM -0300, Glauber Costa wrote:
> On Tue, Jul 14, 2009 at 10:45:22PM +0200, Jan Kiszka wrote:
> > Glauber Costa wrote:
> > > Drop KVM_UPSTREAM around functions we intend to reuse.
> > > This allow us to share code in kvm-all.c, that is equal in qemu-kvm.c
> > >
> > > Signed-off-by: Glauber Costa <glommer@redhat.com>
> > > CC: Jan Kiszka <jan.kiszka@siemens.com>
> >
> > Looks good (and demonstrates nicely how we can merge things in the ideal
> > case).
> neat.
> As per gleb suggestion, I also posted to qemu a patch that gives us on_vcpu().
> We can share more code, once it is there.
>
> Marcelo, can you please merge it?
Patches 6 and 7 contain some tab breakage, is that intentional?
next prev parent reply other threads:[~2009-07-14 21:32 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-14 15:35 [PATCH v3 0/8] Move closer to upstream Glauber Costa
2009-07-14 15:35 ` [PATCH v3 1/8] replace USE_KVM with CONFIG_KVM Glauber Costa
2009-07-14 15:35 ` [PATCH v3 2/8] Do not compile qemu-kvm.c and qemu-kvm-x86.c Glauber Costa
2009-07-14 15:35 ` [PATCH v3 3/8] replace malloc with qemu_malloc Glauber Costa
2009-07-14 15:35 ` [PATCH v3 4/8] fold libkvm-all into standard qemu header Glauber Costa
2009-07-14 15:35 ` [PATCH v3 5/8] duplicate KVMState Glauber Costa
2009-07-14 15:35 ` [PATCH v3 6/8] provide env->kvm_fd Glauber Costa
2009-07-14 15:35 ` [PATCH v3 7/8] use kvm_upstream sw_breakpoints structure Glauber Costa
2009-07-14 15:35 ` [PATCH v3 8/8] reuse upstream breakpoint code Glauber Costa
2009-07-14 20:45 ` Jan Kiszka
2009-07-14 21:01 ` Glauber Costa
2009-07-14 21:31 ` Marcelo Tosatti [this message]
2009-07-14 23:20 ` [PATCH v3 0/8] Move closer to upstream Marcelo Tosatti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090714213121.GA10465@amt.cnet \
--to=mtosatti@redhat.com \
--cc=avi@redhat.com \
--cc=glommer@redhat.com \
--cc=jan.kiszka@web.de \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox