From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Brook Subject: Re: [Qemu-devel] [PATCH] rev5: support colon in filenames Date: Wed, 15 Jul 2009 16:52:17 +0100 Message-ID: <200907151652.19295.paul@codesourcery.com> References: <1245862739.6278.7.camel@localhost> <4A5DF252.50408@us.ibm.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: 7bit Cc: Blue Swirl , linuxram@us.ibm.com, qemu-devel@nongnu.org, Kevin Wolf , Jan Kiszka , "kvm-devel" To: Anthony Liguori Return-path: Received: from mail.codesourcery.com ([65.74.133.4]:54651 "EHLO mail.codesourcery.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755590AbZGOPwV (ORCPT ); Wed, 15 Jul 2009 11:52:21 -0400 In-Reply-To: <4A5DF252.50408@us.ibm.com> Content-Disposition: inline Sender: kvm-owner@vger.kernel.org List-ID: On Wednesday 15 July 2009, Anthony Liguori wrote: > Blue Swirl wrote: > > I bet this won't compile on win32. > > > > Instead of this (IMHO doomed) escape approach, maybe the filename > > parameter could be specified as the next argument, for example: > > -hda format=qcow2,blah,blah,filename_is_next_arg -hda "filename with > > funky characters like ',' ':' & '!'" > > -drive name=hda,if=ide,cache=off -hda foo.img > -drive name=vda,if=virtio,cache=writeback -vda foo.img > -drive name=sdb,if=scsi,unit=1 -sdb boo.img > > But Paul has long objected to having -vda or -sda syntaxes. I do agree > though that the most sane thing to do is to make the filename an > independent argument. I dislike implicit ordering of arguments even less. Having -foo -bar behave differently to -bar -foo is bad. We already have this a bit for things like -net, but splitting something into two as a parsing hack seems really lame. How about -drive args=whatever,unparsed_name=bah Where unparsed_name is defined to be the last argument, and blah is interpreted literally. Paul