From: Marcelo Tosatti <mtosatti@redhat.com>
To: Sheng Yang <sheng@linux.intel.com>
Cc: Avi Kivity <avi@redhat.com>, kvm@vger.kernel.org
Subject: Re: [PATCH] KVM: Discard unnecessary kvm_mmu_flush_tlb() in kvm_mmu_load()
Date: Wed, 15 Jul 2009 16:04:50 -0300 [thread overview]
Message-ID: <20090715190450.GA8665@amt.cnet> (raw)
In-Reply-To: <1247130042-32290-1-git-send-email-sheng@linux.intel.com>
On Thu, Jul 09, 2009 at 05:00:42PM +0800, Sheng Yang wrote:
> set_cr3() should already cover the TLB flushing.
>
> Signed-off-by: Sheng Yang <sheng@linux.intel.com>
> ---
> arch/x86/kvm/mmu.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/x86/kvm/mmu.c b/arch/x86/kvm/mmu.c
> index 231d880..501c11e 100644
> --- a/arch/x86/kvm/mmu.c
> +++ b/arch/x86/kvm/mmu.c
> @@ -2349,8 +2349,8 @@ int kvm_mmu_load(struct kvm_vcpu *vcpu)
> spin_unlock(&vcpu->kvm->mmu_lock);
> if (r)
> goto out;
> + /* set_cr3() should ensure TLB has been flushed */
> kvm_x86_ops->set_cr3(vcpu, vcpu->arch.mmu.root_hpa);
> - kvm_mmu_flush_tlb(vcpu);
> out:
> return r;
> }
> --
> 1.5.4.5
Applied, thanks.
prev parent reply other threads:[~2009-07-15 19:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-09 9:00 [PATCH] KVM: Discard unnecessary kvm_mmu_flush_tlb() in kvm_mmu_load() Sheng Yang
2009-07-13 11:42 ` Sheng Yang
2009-07-13 13:51 ` Marcelo Tosatti
2009-07-13 12:23 ` Avi Kivity
2009-07-13 13:29 ` Sheng Yang
2009-07-15 19:04 ` Marcelo Tosatti [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090715190450.GA8665@amt.cnet \
--to=mtosatti@redhat.com \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=sheng@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox