From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jamie Lokier Subject: Re: [Qemu-devel] [PATCH] rev3: support colon in filenames Date: Wed, 15 Jul 2009 23:51:51 +0100 Message-ID: <20090715225150.GU3056@shareable.org> References: <4A4C754D.10109@redhat.com> <4A4CAD86.9020607@us.ibm.com> <4A4CB39F.5070506@redhat.com> <20090715181405.GB3056@shareable.org> <4A5E4206.20602@web.de> <20090715213635.GN3056@shareable.org> <4A5E4D33.9070901@web.de> <4A5E5545.5060603@us.ibm.com> <20090715223949.GS3056@shareable.org> <4A5E5B00.10304@us.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Jan Kiszka , Kevin Wolf , linuxram@us.ibm.com, qemu-devel@nongnu.org, kvm-devel To: Anthony Liguori Return-path: Received: from mail2.shareable.org ([80.68.89.115]:49147 "EHLO mail2.shareable.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751286AbZGOWvy (ORCPT ); Wed, 15 Jul 2009 18:51:54 -0400 Content-Disposition: inline In-Reply-To: <4A5E5B00.10304@us.ibm.com> Sender: kvm-owner@vger.kernel.org List-ID: Anthony Liguori wrote: > Jamie Lokier wrote: > >Anthony Liguori wrote: > > > >>Jan Kiszka wrote: > >> > >>>We would still have to deal with the fact that so far '\' had no special > >>>meaning on Windows - except that is was the well-known path separator. > >>>So redefining its meaning would break a bit... > >>> > >>> > >>That's the problem. You will break existing Windows users. > >> > >>I know this goes against the current momentum in qemu, but overloading > >>one option with a bunch of parameters seems absolutely silly to me. > >> > >>IMHO, -drive file=foo.img,if=virtio,cache=off should have always been at > >>least three parameters. > >> > > > >That's fine for command lines. I don't necessarily disagree with you. > > > >But how do you propose to handle paths in monitor commands, when the > >path contains a space/quote/whatever as it often does on Windows ("My > >Documents", "Program Files")? > > > > Same basic rules apply. The monitor should use shell-style quoting. So instead of consistency, you like the idea of using different quoting rules for the monitor than for command line arguments? -- Jamie