public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Marcelo Tosatti <mtosatti@redhat.com>
To: Jordan Justen <jordan.l.justen@intel.com>
Cc: kvm-devel <kvm@vger.kernel.org>
Subject: Re: [PATCH 3/3] Update VMX_EPT_IDENTITY_PAGETABLE_ADDR to synchronize with kernel code.
Date: Thu, 16 Jul 2009 15:18:08 -0300	[thread overview]
Message-ID: <20090716181808.GA8641@amt.cnet> (raw)
In-Reply-To: <1247767342-13519-3-git-send-email-jordan.l.justen@intel.com>

On Thu, Jul 16, 2009 at 11:02:22AM -0700, Jordan Justen wrote:
> Although VMX_EPT_IDENTITY_PAGETABLE_ADDR does not appear to be used within
> qemu-kvm, this change mirrors a similar change in the kernel kvm code.
> 
> The purpose is to move the KVM 'EPT Identity Pages' from:
>   0xfffbc000-0xfffbcfff
> to:
>   0xfeffc000-0xfeffcfff
> 
> The step is required to free up the 0xff000000-0xffffffff (16MB) range
> for use with bios.bin.
> 
> The KVM kernel change depends upon a change to kvm/bios/rombios.c so the bios
> INT15-E820 function will properly reserve the new location.
> 
> Signed-off-by: Jordan Justen <jordan.l.justen@intel.com>
> ---
>  kvm/include/x86/asm/vmx.h |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/kvm/include/x86/asm/vmx.h b/kvm/include/x86/asm/vmx.h
> index df8d4f9..99e2bb9 100644
> --- a/kvm/include/x86/asm/vmx.h
> +++ b/kvm/include/x86/asm/vmx.h
> @@ -403,7 +403,7 @@ enum vmcs_field {
>  #define VMX_EPT_EXECUTABLE_MASK			0x4ull
>  #define VMX_EPT_IGMT_BIT    			(1ull << 6)
>  
> -#define VMX_EPT_IDENTITY_PAGETABLE_ADDR		0xfffbc000ul
> +#define VMX_EPT_IDENTITY_PAGETABLE_ADDR		0xfeffc000ul

Won't this conflict with an older BIOS? (the e820 reserved entry on
older qemu-kvm+bios will not cover the EPT identity table on kernels
with this patch).

Perhaps add a new ioctl (similar to the tss one) to so userspace can set
the address?

>  
>  
>  #define ASM_VMX_VMCLEAR_RAX       ".byte 0x66, 0x0f, 0xc7, 0x30"
> -- 
> 1.6.0.4
> 
> --
> To unsubscribe from this list: send the line "unsubscribe kvm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2009-07-16 18:18 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-16 18:02 [PATCH 1/3] Update qemu-kvm bios to allow for a larger bios image Jordan Justen
2009-07-16 18:02 ` [PATCH 2/3] Move qemu-kvm 'VMC TSS Pages' to allow a larger BIOS image Jordan Justen
2009-07-16 18:02   ` [PATCH 3/3] Update VMX_EPT_IDENTITY_PAGETABLE_ADDR to synchronize with kernel code Jordan Justen
2009-07-16 18:18     ` Marcelo Tosatti [this message]
2009-07-16 18:48       ` Jordan Justen
2009-07-16 19:14         ` Marcelo Tosatti
2009-07-17  2:24           ` Yang, Sheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090716181808.GA8641@amt.cnet \
    --to=mtosatti@redhat.com \
    --cc=jordan.l.justen@intel.com \
    --cc=kvm@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox