From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marcelo Tosatti Subject: Re: [PATCH 2/5] reuse kvm_vm_ioctl Date: Fri, 17 Jul 2009 12:39:17 -0300 Message-ID: <20090717153917.GA4978@amt.cnet> References: <1247675503-7106-1-git-send-email-glommer@redhat.com> <1247675503-7106-2-git-send-email-glommer@redhat.com> <1247675503-7106-3-git-send-email-glommer@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: kvm@vger.kernel.org, avi@redhat.com To: Glauber Costa Return-path: Received: from mx2.redhat.com ([66.187.237.31]:48002 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934703AbZGQPja (ORCPT ); Fri, 17 Jul 2009 11:39:30 -0400 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n6HFdUwJ031748 for ; Fri, 17 Jul 2009 11:39:30 -0400 Content-Disposition: inline In-Reply-To: <1247675503-7106-3-git-send-email-glommer@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Wed, Jul 15, 2009 at 12:31:40PM -0400, Glauber Costa wrote: > Start using kvm_vm_ioctl's code. > For type safety, delete vm_fd from kvm_context entirely, so the > compiler can play along with us helping to detect errors I might > have made. > > Signed-off-by: Glauber Costa > --- > kvm-all.c | 2 ++ > qemu-kvm-x86.c | 18 +++++++++--------- > qemu-kvm.c | 52 ++++++++++++++++++++++++++-------------------------- > qemu-kvm.h | 6 +++--- > 4 files changed, 40 insertions(+), 38 deletions(-) > @@ -516,7 +516,7 @@ kvm_vcpu_context_t kvm_create_vcpu(CPUState *env, int id) > vcpu_ctx->kvm = kvm; > vcpu_ctx->id = id; > > - r = ioctl(kvm->vm_fd, KVM_CREATE_VCPU, id); > + r = kvm_vm_ioctl(kvm_state, KVM_CREATE_VCPU, id); > if (r == -1) { > fprintf(stderr, "kvm_create_vcpu: %m\n"); int kvm_vm_ioctl(KVMState *s, int type, ...) { ... if (ret == -1) ret = -errno; } Is that fine?