Re: [PATCH] enable x2APIC without interrupt remapping under KVM

Gleb Natapov
2009-07-19T16:41:10Z

On Sun, Jul 19, 2009 at 06:27:35PM +0200, Ingo Molnar wrote:
>
> * Gleb Natapov <gleb@redhat.com> wrote:
>
> > + if (!ret) {
> > + /* IR is required if there is APIC ID > 255 even when running
> > + * under KVM
> > + */
>
> Eeek.
>
> > + if (x2apic_preenabled) {
> > + panic("x2apic enabled by bios. But IR enabling failed."
> > + " Check that CONFIG_X86_X2APIC and CONFIG_INTR_REMAP are"
> > + " enabled.");
>
> We dont want to break such messages mid-line, it makes it hard to
> git-grep for them. Also, the '. But' looks weird.

So what should I do? Make really long line?

--
Gleb.