From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jesse Barnes Subject: Re: [PATCHv5] uio: add generic driver for PCI 2.3 devices Date: Mon, 20 Jul 2009 16:15:42 -0700 Message-ID: <20090720161542.25dcddb4@jbarnes-g45> References: <20090720072934.GA12509@redhat.com> <20090720190942.GB7604@local> <20090720195227.GB19009@redhat.com> <20090720195536.GA30483@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: "Michael S. Tsirkin" , "Hans J. Koch" , anthony@codemonkey.ws, avi@redhat.com, kvm@vger.kernel.org, chrisw@redhat.com, linux-kernel@vger.kernel.org To: Greg KH Return-path: In-Reply-To: <20090720195536.GA30483@suse.de> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On Mon, 20 Jul 2009 12:55:36 -0700 Greg KH wrote: > On Mon, Jul 20, 2009 at 10:52:27PM +0300, Michael S. Tsirkin wrote: > > On Mon, Jul 20, 2009 at 09:09:43PM +0200, Hans J. Koch wrote: > > > On Mon, Jul 20, 2009 at 10:29:34AM +0300, Michael S. Tsirkin > > > wrote: > > > > This adds a generic uio driver that can bind to any PCI > > > > device. First user will be virtualization where a qemu > > > > userspace process needs to give guest OS access to the device. > > > > > > > > Interrupts are handled using the Interrupt Disable bit in the > > > > PCI command register and Interrupt Status bit in the PCI status > > > > register. All devices compliant to PCI 2.3 (circa 2002) and > > > > all compliant PCI Express devices should support these bits. > > > > Driver detects this support, and won't bind to devices which do > > > > not support the Interrupt Disable Bit in the command register. > > > > > > > > It's expected that more features of interest to virtualization > > > > will be added to this driver in the future. Possibilities are: > > > > mmap for device resources, MSI/MSI-X, eventfd (to interface > > > > with kvm), iommu. > > > > > > Thanks for adding the docs! Looks alright to me. > > > > > > Thanks, > > > Hans > > > > > > > > > > > Signed-off-by: Michael S. Tsirkin > > > > Acked-by: Chris Wright > > > > > > Signed-off-by: Hans J. Koch > > > > Jesse just acked this patch in a private mail, as well. > > Acked-by: Jesse Barnes > > Odd, but ok... I just replied to Michael's off-list forward of some of the thread that I missed, I'm not trying to hide anything. :) Move along, nothing to see here... -- Jesse Barnes, Intel Open Source Technology Center