From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gleb Natapov Subject: Re: [PATCH 6/9] remove kvm_in* functions Date: Tue, 21 Jul 2009 15:18:42 +0300 Message-ID: <20090721121842.GC5638@redhat.com> References: <1248131416-11272-1-git-send-email-glommer@redhat.com> <1248131416-11272-2-git-send-email-glommer@redhat.com> <1248131416-11272-3-git-send-email-glommer@redhat.com> <1248131416-11272-4-git-send-email-glommer@redhat.com> <1248131416-11272-5-git-send-email-glommer@redhat.com> <1248131416-11272-6-git-send-email-glommer@redhat.com> <1248131416-11272-7-git-send-email-glommer@redhat.com> <20090721061106.GV5638@redhat.com> <20090721122324.GJ4019@poweredge.glommer> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: kvm@vger.kernel.org, avi@redhat.com To: Glauber Costa Return-path: Received: from mx2.redhat.com ([66.187.237.31]:46120 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755482AbZGUMSo (ORCPT ); Tue, 21 Jul 2009 08:18:44 -0400 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n6LCIiOu019677 for ; Tue, 21 Jul 2009 08:18:44 -0400 Content-Disposition: inline In-Reply-To: <20090721122324.GJ4019@poweredge.glommer> Sender: kvm-owner@vger.kernel.org List-ID: On Tue, Jul 21, 2009 at 09:23:24AM -0300, Glauber Costa wrote: > On Tue, Jul 21, 2009 at 09:11:06AM +0300, Gleb Natapov wrote: > > On Mon, Jul 20, 2009 at 07:10:13PM -0400, Glauber Costa wrote: > > > We can use plain qemu's here, and save a couple of lines/complexity. > > > I'm leaving outb for later, because the SMM thing makes it a little bit > > > less trivial. > > > > > I think you can remove all this black SMM magic from kvm_outb(). It is > > handled in acpi.c now. Just booted WindowsXP with all this crap deleted. > Cool, I figured it out, but as I said, it is much less trivial. > If you agree with removing it, a new patch will follow after this series is > in > I agree, but I am not the maintainer :) -- Gleb.