From: Marcelo Tosatti <mtosatti@redhat.com>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: kvm-devel <kvm@vger.kernel.org>
Subject: Re: [PATCH] KVM: VMX: Fix locking imbalance on emulation failure
Date: Tue, 21 Jul 2009 14:35:14 -0300 [thread overview]
Message-ID: <20090721173514.GE6959@amt.cnet> (raw)
In-Reply-To: <4A657F9B.1090305@siemens.com>
On Tue, Jul 21, 2009 at 10:43:07AM +0200, Jan Kiszka wrote:
> We have to disable preemption and IRQs on every exit from
> handle_invalid_guest_state, otherwise we generate at least a
> preempt_disable imbalance.
>
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
>
> arch/x86/kvm/vmx.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
> index 3a75db3..7a8d464 100644
> --- a/arch/x86/kvm/vmx.c
> +++ b/arch/x86/kvm/vmx.c
> @@ -3335,7 +3335,7 @@ static void handle_invalid_guest_state(struct kvm_vcpu *vcpu,
>
> if (err != EMULATE_DONE) {
> kvm_report_emulation_failure(vcpu, "emulation failure");
> - return;
> + break;
> }
>
> if (signal_pending(current))
Applied, thanks.
prev parent reply other threads:[~2009-07-21 17:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-21 8:43 [PATCH] KVM: VMX: Fix locking imbalance on emulation failure Jan Kiszka
2009-07-21 17:35 ` Marcelo Tosatti [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090721173514.GE6959@amt.cnet \
--to=mtosatti@redhat.com \
--cc=jan.kiszka@siemens.com \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox