From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yolkfull Chow Subject: Re: [PATCH] Add a kvm subtest -- pci_hotplug, which supports both Windows OS and Linux OS. Date: Thu, 23 Jul 2009 15:18:17 +0800 Message-ID: <20090723071817.GA2740@aFu.nay.redhat.com> References: <1283926593.702711248067671557.JavaMail.root@zmail07.collab.prod.int.phx2.redhat.com> <4A64032A.8090804@redhat.com> <20090720070110.GA17650@aFu.nay.redhat.com> <4A641AD4.2030502@redhat.com> <20090721061121.GA5975@dhcp-66-70-57.nay.redhat.com> <4A65721B.9070002@redhat.com> Reply-To: Yolkfull Chow Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: kvm@vger.kernel.org, autotest@test.kernel.org, Vadim Rozenfeld To: lmr@redhat.com Return-path: Received: from mx2.redhat.com ([66.187.237.31]:58877 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753093AbZGWHSN (ORCPT ); Thu, 23 Jul 2009 03:18:13 -0400 Content-Disposition: inline In-Reply-To: <4A65721B.9070002@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Tue, Jul 21, 2009 at 10:45:31AM +0300, Yaniv Kaul wrote: > On 7/21/2009 9:11 AM, Yolkfull Chow wrote: > > >> >>>> >>>> >>>>>> Previously, I used 'create partition primary' to verify whether the disk could be formatted but always got an error: >>>>>> --- >>>>>> diskpart has encountered an error... >>>>>> --- >>>>>> And then I found the SCSI disk was added to Windows guest was read-only. So I changed the format command to be 'detail disk' temporarily. >>>>>> >>>>>> >>>>>> >>>>> Interesting - how did that happen? Lets see your command line, and >>>>> probably 'info block' from the monitor. Are you saying that hot-plugged >>>>> drives are added as r/o? >>>>> >>>>> >>>> I am afraid yes. After pci_add (monitor command: pci_add pci_addr=auto storage >>>> file=/tmp/stg.qcow2,if=scsi) the SCSI block device, 'info block' will >>>> show the scsi0-hd0 device is 'ro=0' whereas when I 'create partition >>>> primary' on this selected disk in diskpart tool, error message will be raised that the disk is >>>> write protected. >>>> >>>> >>> Well, that doesn't sound like the desired behavior. Work with the KVM >>> developers on this. >>> >> Hi Yaniv, following is the output from Windows guest: >> >> --- >> Microsoft DiskPart version 6.0.6001 >> Copyright (C) 1999-2007 Microsoft Corporation. >> On computer: WIN-Q18A9GP5ECI >> >> Disk 1 is now the selected disk. >> >> DiskPart has encountered an error: The media is write protected. >> See the System Event Log for more information. >> >> Have you ever seen this error during format newly added SCSI block >> device? >> >> The contents of my diskpart script file: >> --- >> select disk 1 >> > > online > >> create partition primary >> exit >> --- >> >> > I didn't use a script - nor have I ever hot-plugged a disk, but it does > seem to happen to me as well now - the 2nd disk (the first is IDE) is > indeed seems to be R/O. > I'll look into it. Hi Lucas, did you notice this problem happened on Windows guest? What's your opinion about the patch pci_hotplug,send or wait? I think I can still send the patch for now, and just use 'detail disk' which doesn't format the newly added disk in diskpart script. As soon as we have a solution, I can submit a patch to fix it. Moreover, nic_virtio and block_virtio for Windows section will be disabled in config file as well since both drivers don't work well now. What do you think? Does anyone others has any suggestions/comments? Thanks in advance. :-) Regards, Yolkfull > > >>> >>>> >>>> >>>>> Also, you can always add an already formatted drive. Just create a qcow >>>>> drive in another instance, format it properly and use it. >>>>> >>>>> >>>>> > > Any result with an already formatted drive? > Y. > > -- > To unsubscribe from this list: send the line "unsubscribe kvm" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html