From: "Michael S. Tsirkin" <mst@redhat.com>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: Christian Borntraeger <borntraeger@de.ibm.com>,
virtualization@lists.linux-foundation.org,
Anthony Liguori <anthony@codemonkey.ws>,
kvm@vger.kernel.org, avi@redhat.com,
Carsten Otte <cotte@de.ibm.com>,
t@redhat.com
Subject: Re: [PATCH 1/2] virtio: fix memory leak on device removal
Date: Thu, 23 Jul 2009 13:27:14 +0300 [thread overview]
Message-ID: <20090723102714.GD10860@redhat.com> (raw)
In-Reply-To: <200907231356.59681.rusty@rustcorp.com.au>
On Thu, Jul 23, 2009 at 01:56:58PM +0930, Rusty Russell wrote:
> On Wed, 22 Jul 2009 01:29:09 am Michael S. Tsirkin wrote:
> > Free up msi vector tables.
>
> Michael, this papers over the bug, but doesn't actually fix the problem.
>
> The problem is that vp_free_vectors() does not do the reverse of
> vp_request_vectors. If the author (you) can't get it right, what hope the
> rest of us?
I agree. This code belongs in free_vectors.
And might as well reset the pointers to make the reversal complete.
> Indeed, if you look harder, you'll see another leak caused by this problem,
> which your patch *didn't* fix.
Couldn't spot it yet. I'll send out a fixed patch, see if I got
everything covered.
> Thanks,
> Rusty.
> --
> To unsubscribe from this list: send the line "unsubscribe kvm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2009-07-23 10:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1248181714.git.mst@redhat.com>
2009-07-21 15:59 ` [PATCH 1/2] virtio: fix memory leak on device removal Michael S. Tsirkin
2009-07-21 16:03 ` Michael S. Tsirkin
2009-07-23 4:26 ` Rusty Russell
2009-07-23 10:27 ` Michael S. Tsirkin [this message]
2009-07-21 15:59 ` [PATCH 2/2] virtio: fix double free_irq Michael S. Tsirkin
2009-07-23 4:40 ` Rusty Russell
2009-07-23 9:08 ` Michael S. Tsirkin
2009-07-23 10:20 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090723102714.GD10860@redhat.com \
--to=mst@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=avi@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=cotte@de.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
--cc=t@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).