From: Glauber Costa <glommer@redhat.com>
To: Avi Kivity <avi@redhat.com>
Cc: kvm@vger.kernel.org, Marcelo Tosatti <mtosatti@redhat.com>
Subject: Re: [PATCH v2 2/6] reuse env stop and stopped states
Date: Mon, 27 Jul 2009 21:48:22 -0300 [thread overview]
Message-ID: <20090728004822.GQ4776@poweredge.glommer> (raw)
In-Reply-To: <4A6DCB33.5020008@redhat.com>
On Mon, Jul 27, 2009 at 06:43:47PM +0300, Avi Kivity wrote:
> On 07/22/2009 01:13 AM, Glauber Costa wrote:
>> qemu CPUState already provides "stop" and "stopped" states. And they
>> mean exactly that. There is no need for us to provide our own.
>>
>>
>
> This patch (known as dd0e1c1a589 in qemu-kvm.git) breaks reboot. My
> test case is FC6 i386 -smp 2, running the reboot command in rc.local.
> In about 15 minutes qemu hangs hard. Please check what's gone wrong.
I found out that doing kill -38 <your_pid> makes it run again, so we're likely
hanging somewhere while holding qemu_mutex. The state of the process is "D",
so we're holding qemu_mutex, and then calling something that can block.
It's hard for me to believe that this patch introduced it. At best, it might have
made it more likely. Also, I also verified that it sometimes takes a while until
it happen for the first time. Are you sure this is the first patch that makes it happen?
next prev parent reply other threads:[~2009-07-28 0:41 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-21 22:13 [PATCH v2 0/6] Glauber Costa
2009-07-21 22:13 ` [PATCH v2 1/6] remove kvm_in* functions Glauber Costa
2009-07-21 22:13 ` [PATCH v2 2/6] reuse env stop and stopped states Glauber Costa
2009-07-21 22:13 ` [PATCH v2 3/6] remove kvm_abi variable Glauber Costa
2009-07-21 22:13 ` [PATCH v2 4/6] remove created from kvm_state Glauber Costa
2009-07-21 22:13 ` [PATCH v2 5/6] remove kvm_specific kvm_out* functions Glauber Costa
2009-07-21 22:13 ` [PATCH v2 6/6] remove kvm_mmio_read and kvm_mmio_write Glauber Costa
2009-07-25 15:24 ` Marcelo Tosatti
2009-07-27 17:47 ` Glauber Costa
2009-07-22 19:50 ` [PATCH v2 5/6] remove kvm_specific kvm_out* functions Marcelo Tosatti
2009-07-23 5:47 ` Gleb Natapov
2009-07-22 19:51 ` [PATCH v2 3/6] remove kvm_abi variable Marcelo Tosatti
2009-07-27 15:43 ` [PATCH v2 2/6] reuse env stop and stopped states Avi Kivity
2009-07-28 0:48 ` Glauber Costa [this message]
2009-07-28 6:17 ` Avi Kivity
2009-07-28 6:24 ` Gleb Natapov
2009-07-28 6:28 ` Avi Kivity
2009-07-28 6:29 ` Gleb Natapov
2009-07-28 6:31 ` Avi Kivity
2009-07-28 13:45 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090728004822.GQ4776@poweredge.glommer \
--to=glommer@redhat.com \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox