* Re: [PATCH] Add a kvm subtest -- pci_hotplug, which supports both Windows OS and Linux OS.
2009-07-21 7:45 ` [PATCH] Add a kvm subtest -- pci_hotplug, which supports both Windows OS and Linux OS Yaniv Kaul
@ 2009-07-21 8:29 ` Yolkfull Chow
2009-07-21 9:01 ` Yolkfull Chow
2009-07-23 7:18 ` Yolkfull Chow
2 siblings, 0 replies; 6+ messages in thread
From: Yolkfull Chow @ 2009-07-21 8:29 UTC (permalink / raw)
To: Yaniv Kaul; +Cc: kvm, lmr, autotest, Vadim Rozenfeld
On Tue, Jul 21, 2009 at 10:45:31AM +0300, Yaniv Kaul wrote:
> On 7/21/2009 9:11 AM, Yolkfull Chow wrote:
>
> <SNIP>
>>
>>>>
>>>>
>>>>>> Previously, I used 'create partition primary' to verify whether the disk could be formatted but always got an error:
>>>>>> ---
>>>>>> diskpart has encountered an error...
>>>>>> ---
>>>>>> And then I found the SCSI disk was added to Windows guest was read-only. So I changed the format command to be 'detail disk' temporarily.
>>>>>>
>>>>>>
>>>>>>
>>>>> Interesting - how did that happen? Lets see your command line, and
>>>>> probably 'info block' from the monitor. Are you saying that hot-plugged
>>>>> drives are added as r/o?
>>>>>
>>>>>
>>>> I am afraid yes. After pci_add (monitor command: pci_add pci_addr=auto storage
>>>> file=/tmp/stg.qcow2,if=scsi) the SCSI block device, 'info block' will
>>>> show the scsi0-hd0 device is 'ro=0' whereas when I 'create partition
>>>> primary' on this selected disk in diskpart tool, error message will be raised that the disk is
>>>> write protected.
>>>>
>>>>
>>> Well, that doesn't sound like the desired behavior. Work with the KVM
>>> developers on this.
>>>
>> Hi Yaniv, following is the output from Windows guest:
>>
>> ---
>> Microsoft DiskPart version 6.0.6001
>> Copyright (C) 1999-2007 Microsoft Corporation.
>> On computer: WIN-Q18A9GP5ECI
>>
>> Disk 1 is now the selected disk.
>>
>> DiskPart has encountered an error: The media is write protected.
>> See the System Event Log for more information.
>>
>> Have you ever seen this error during format newly added SCSI block
>> device?
>>
>> The contents of my diskpart script file:
>> ---
>> select disk 1
>>
>
> online
>
>> create partition primary
>> exit
>> ---
>>
>>
> I didn't use a script - nor have I ever hot-plugged a disk, but it does
> seem to happen to me as well now - the 2nd disk (the first is IDE) is
> indeed seems to be R/O.
> I'll look into it.
>
>
>>>
>>>>
>>>>
>>>>> Also, you can always add an already formatted drive. Just create a qcow
>>>>> drive in another instance, format it properly and use it.
>>>>>
>>>>>
>>>>>
>
> Any result with an already formatted drive?
No, haven't got a chance to try that. :-(
> Y.
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Add a kvm subtest -- pci_hotplug, which supports both Windows OS and Linux OS.
2009-07-21 7:45 ` [PATCH] Add a kvm subtest -- pci_hotplug, which supports both Windows OS and Linux OS Yaniv Kaul
2009-07-21 8:29 ` Yolkfull Chow
@ 2009-07-21 9:01 ` Yolkfull Chow
2009-07-23 7:18 ` Yolkfull Chow
2 siblings, 0 replies; 6+ messages in thread
From: Yolkfull Chow @ 2009-07-21 9:01 UTC (permalink / raw)
To: Yaniv Kaul; +Cc: kvm, lmr, autotest, Vadim Rozenfeld
On Tue, Jul 21, 2009 at 10:45:31AM +0300, Yaniv Kaul wrote:
> On 7/21/2009 9:11 AM, Yolkfull Chow wrote:
>
> <SNIP>
>>
>>>>
>>>>
>>>>>> Previously, I used 'create partition primary' to verify whether the disk could be formatted but always got an error:
>>>>>> ---
>>>>>> diskpart has encountered an error...
>>>>>> ---
>>>>>> And then I found the SCSI disk was added to Windows guest was read-only. So I changed the format command to be 'detail disk' temporarily.
>>>>>>
>>>>>>
>>>>>>
>>>>> Interesting - how did that happen? Lets see your command line, and
>>>>> probably 'info block' from the monitor. Are you saying that hot-plugged
>>>>> drives are added as r/o?
>>>>>
>>>>>
>>>> I am afraid yes. After pci_add (monitor command: pci_add pci_addr=auto storage
>>>> file=/tmp/stg.qcow2,if=scsi) the SCSI block device, 'info block' will
>>>> show the scsi0-hd0 device is 'ro=0' whereas when I 'create partition
>>>> primary' on this selected disk in diskpart tool, error message will be raised that the disk is
>>>> write protected.
>>>>
>>>>
>>> Well, that doesn't sound like the desired behavior. Work with the KVM
>>> developers on this.
>>>
>> Hi Yaniv, following is the output from Windows guest:
>>
>> ---
>> Microsoft DiskPart version 6.0.6001
>> Copyright (C) 1999-2007 Microsoft Corporation.
>> On computer: WIN-Q18A9GP5ECI
>>
>> Disk 1 is now the selected disk.
>>
>> DiskPart has encountered an error: The media is write protected.
>> See the System Event Log for more information.
>>
>> Have you ever seen this error during format newly added SCSI block
>> device?
>>
>> The contents of my diskpart script file:
>> ---
>> select disk 1
>>
>
> online
>
>> create partition primary
>> exit
>> ---
>>
>>
> I didn't use a script - nor have I ever hot-plugged a disk, but it does
> seem to happen to me as well now - the 2nd disk (the first is IDE) is
> indeed seems to be R/O.
> I'll look into it.
>
>
>>>
>>>>
>>>>
>>>>> Also, you can always add an already formatted drive. Just create a qcow
>>>>> drive in another instance, format it properly and use it.
>>>>>
>>>>>
>>>>>
>
> Any result with an already formatted drive?
I just tried, got same result -- write protected. Steps:
1. qemu-img create -f raw /tmp/stg.raw 1G
2. mkfs.vfat /tmp/stg.raw
3. hot_add the block device
4. diskpart to 'create partition primary' on the newly added disk
Did I make any mistake? Or I need also try to hot_add a drive which has
been installed an OS?
> Y.
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Add a kvm subtest -- pci_hotplug, which supports both Windows OS and Linux OS.
2009-07-21 7:45 ` [PATCH] Add a kvm subtest -- pci_hotplug, which supports both Windows OS and Linux OS Yaniv Kaul
2009-07-21 8:29 ` Yolkfull Chow
2009-07-21 9:01 ` Yolkfull Chow
@ 2009-07-23 7:18 ` Yolkfull Chow
2009-07-28 5:03 ` [Autotest] " Lucas Meneghel Rodrigues
2 siblings, 1 reply; 6+ messages in thread
From: Yolkfull Chow @ 2009-07-23 7:18 UTC (permalink / raw)
To: lmr; +Cc: kvm, autotest, Vadim Rozenfeld
On Tue, Jul 21, 2009 at 10:45:31AM +0300, Yaniv Kaul wrote:
> On 7/21/2009 9:11 AM, Yolkfull Chow wrote:
>
> <SNIP>
>>
>>>>
>>>>
>>>>>> Previously, I used 'create partition primary' to verify whether the disk could be formatted but always got an error:
>>>>>> ---
>>>>>> diskpart has encountered an error...
>>>>>> ---
>>>>>> And then I found the SCSI disk was added to Windows guest was read-only. So I changed the format command to be 'detail disk' temporarily.
>>>>>>
>>>>>>
>>>>>>
>>>>> Interesting - how did that happen? Lets see your command line, and
>>>>> probably 'info block' from the monitor. Are you saying that hot-plugged
>>>>> drives are added as r/o?
>>>>>
>>>>>
>>>> I am afraid yes. After pci_add (monitor command: pci_add pci_addr=auto storage
>>>> file=/tmp/stg.qcow2,if=scsi) the SCSI block device, 'info block' will
>>>> show the scsi0-hd0 device is 'ro=0' whereas when I 'create partition
>>>> primary' on this selected disk in diskpart tool, error message will be raised that the disk is
>>>> write protected.
>>>>
>>>>
>>> Well, that doesn't sound like the desired behavior. Work with the KVM
>>> developers on this.
>>>
>> Hi Yaniv, following is the output from Windows guest:
>>
>> ---
>> Microsoft DiskPart version 6.0.6001
>> Copyright (C) 1999-2007 Microsoft Corporation.
>> On computer: WIN-Q18A9GP5ECI
>>
>> Disk 1 is now the selected disk.
>>
>> DiskPart has encountered an error: The media is write protected.
>> See the System Event Log for more information.
>>
>> Have you ever seen this error during format newly added SCSI block
>> device?
>>
>> The contents of my diskpart script file:
>> ---
>> select disk 1
>>
>
> online
>
>> create partition primary
>> exit
>> ---
>>
>>
> I didn't use a script - nor have I ever hot-plugged a disk, but it does
> seem to happen to me as well now - the 2nd disk (the first is IDE) is
> indeed seems to be R/O.
> I'll look into it.
Hi Lucas, did you notice this problem happened on Windows guest? What's
your opinion about the patch pci_hotplug,send or wait?
I think I can still send the patch for now, and just use 'detail disk' which doesn't format the newly added
disk in diskpart script. As soon as we have a solution, I can submit a
patch to fix it. Moreover, nic_virtio and block_virtio for Windows section will be
disabled in config file as well since both drivers don't work well now.
What do you think? Does anyone others has any suggestions/comments?
Thanks in advance. :-)
Regards,
Yolkfull
>
>
>>>
>>>>
>>>>
>>>>> Also, you can always add an already formatted drive. Just create a qcow
>>>>> drive in another instance, format it properly and use it.
>>>>>
>>>>>
>>>>>
>
> Any result with an already formatted drive?
> Y.
>
> --
> To unsubscribe from this list: send the line "unsubscribe kvm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Autotest] [PATCH] Add a kvm subtest -- pci_hotplug, which supports both Windows OS and Linux OS.
2009-07-23 7:18 ` Yolkfull Chow
@ 2009-07-28 5:03 ` Lucas Meneghel Rodrigues
2009-07-28 9:01 ` Yolkfull Chow
0 siblings, 1 reply; 6+ messages in thread
From: Lucas Meneghel Rodrigues @ 2009-07-28 5:03 UTC (permalink / raw)
To: Yolkfull Chow; +Cc: autotest, Vadim Rozenfeld, kvm
On Thu, Jul 23, 2009 at 4:18 AM, Yolkfull Chow<yzhou@redhat.com> wrote:
>>> Hi Yaniv, following is the output from Windows guest:
>>>
>>> ---
>>> Microsoft DiskPart version 6.0.6001
>>> Copyright (C) 1999-2007 Microsoft Corporation.
>>> On computer: WIN-Q18A9GP5ECI
>>>
>>> Disk 1 is now the selected disk.
>>>
>>> DiskPart has encountered an error: The media is write protected.
>>> See the System Event Log for more information.
>>>
>>> Have you ever seen this error during format newly added SCSI block
>>> device?
>>>
>>> The contents of my diskpart script file:
>>> ---
>>> select disk 1
>>>
>>
>> online
>>
>>> create partition primary
>>> exit
>>> ---
>>>
>>>
>> I didn't use a script - nor have I ever hot-plugged a disk, but it does
>> seem to happen to me as well now - the 2nd disk (the first is IDE) is
>> indeed seems to be R/O.
>> I'll look into it.
>
> Hi Lucas, did you notice this problem happened on Windows guest? What's
> your opinion about the patch pci_hotplug,send or wait?
Hi Yolkfull, sorry for the delay answering. Yes, I did see the problem
on windows guests. About the test itself, it looks good and I am
making more tests before integrating it. Interestingly I tried it with
older fedora versions and lspci doesn't seem to be able to recognize
the newly added devices. High time we add step files and data for F10
and F11 on the default config file.
> I think I can still send the patch for now, and just use 'detail disk' which doesn't format the newly added
> disk in diskpart script. As soon as we have a solution, I can submit a
> patch to fix it. Moreover, nic_virtio and block_virtio for Windows section will be
> disabled in config file as well since both drivers don't work well now.
Ok, if you have an updated patch, please send it. Let's try to get all
the problems addressed as soon as possible.
Thanks for your work on this!
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Autotest] [PATCH] Add a kvm subtest -- pci_hotplug, which supports both Windows OS and Linux OS.
2009-07-28 5:03 ` [Autotest] " Lucas Meneghel Rodrigues
@ 2009-07-28 9:01 ` Yolkfull Chow
0 siblings, 0 replies; 6+ messages in thread
From: Yolkfull Chow @ 2009-07-28 9:01 UTC (permalink / raw)
To: Lucas Meneghel Rodrigues; +Cc: autotest, Vadim Rozenfeld, kvm
On Tue, Jul 28, 2009 at 02:03:10AM -0300, Lucas Meneghel Rodrigues wrote:
> On Thu, Jul 23, 2009 at 4:18 AM, Yolkfull Chow<yzhou@redhat.com> wrote:
> >>> Hi Yaniv, following is the output from Windows guest:
> >>>
> >>> ---
> >>> Microsoft DiskPart version 6.0.6001
> >>> Copyright (C) 1999-2007 Microsoft Corporation.
> >>> On computer: WIN-Q18A9GP5ECI
> >>>
> >>> Disk 1 is now the selected disk.
> >>>
> >>> DiskPart has encountered an error: The media is write protected.
> >>> See the System Event Log for more information.
> >>>
> >>> Have you ever seen this error during format newly added SCSI block
> >>> device?
> >>>
> >>> The contents of my diskpart script file:
> >>> ---
> >>> select disk 1
> >>>
> >>
> >> online
> >>
> >>> create partition primary
> >>> exit
> >>> ---
> >>>
> >>>
> >> I didn't use a script - nor have I ever hot-plugged a disk, but it does
> >> seem to happen to me as well now - the 2nd disk (the first is IDE) is
> >> indeed seems to be R/O.
> >> I'll look into it.
> >
> > Hi Lucas, did you notice this problem happened on Windows guest? What's
> > your opinion about the patch pci_hotplug,send or wait?
>
> Hi Yolkfull, sorry for the delay answering. Yes, I did see the problem
> on windows guests. About the test itself, it looks good and I am
> making more tests before integrating it. Interestingly I tried it with
> older fedora versions and lspci doesn't seem to be able to recognize
> the newly added devices. High time we add step files and data for F10
> and F11 on the default config file.
>
> > I think I can still send the patch for now, and just use 'detail disk' which doesn't format the newly added
> > disk in diskpart script. As soon as we have a solution, I can submit a
> > patch to fix it. Moreover, nic_virtio and block_virtio for Windows section will be
> > disabled in config file as well since both drivers don't work well now.
>
> Ok, if you have an updated patch, please send it. Let's try to get all
> the problems addressed as soon as possible.
>
> Thanks for your work on this!
Ok, I will post it here soon after I finish current case. Thanks, Lucas. :-)
Regards,
^ permalink raw reply [flat|nested] 6+ messages in thread