public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Marcelo Tosatti <mtosatti@redhat.com>
To: Jordan Justen <jordan.l.justen@intel.com>
Cc: kvm-devel <kvm@vger.kernel.org>, "Yang, Sheng" <sheng.yang@intel.com>
Subject: Re: [PATCH 1/3] Update BIOS INT15-E820 to allow a larger BIOS image
Date: Tue, 28 Jul 2009 11:40:34 -0300	[thread overview]
Message-ID: <20090728144034.GA5084@amt.cnet> (raw)
In-Reply-To: <1248654233-29845-2-git-send-email-jordan.l.justen@intel.com>

On Sun, Jul 26, 2009 at 05:23:51PM -0700, Jordan Justen wrote:
> The bios will now reserve more memory via the E820 functions.
> 
> Note that the standard KVM BIOS will most likely not make use of
> this expanded BIOS region.  This change will synchronize
> the BIOS INT15-E820 reservations to match other changes that
> will allow alternate BIOS images to be larger in size.
> 
> Previously the BIOS reserved:
>   0xfffbc000-0xfffbcfff -   4KB - EPT identity mapping pages
>   0xfffbd000-0xfffbffff -  12KB - TSS pages
>   0xfffc0000-0xffffffff - 256KB - Max bios.bin (usually top 128KB is used)
> 
> Now the BIOS will reserve:
>   0xfeffc000-0xfeffcfff -   4KB - EPT identity mapping pages
>   0xfeffd000-0xfeffffff -  12KB - TSS Pages
>   0xff000000-0xffffffff -  16MB - Max bios.bin
> 
> Signed-off-by: Jordan Justen <jordan.l.justen@intel.com>
> ---
>  kvm/bios/rombios.c |    8 ++++----
>  1 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/kvm/bios/rombios.c b/kvm/bios/rombios.c
> index 6186199..2d0c153 100644
> --- a/kvm/bios/rombios.c
> +++ b/kvm/bios/rombios.c
> @@ -4596,14 +4596,14 @@ ASM_END
>                      case 5:
>                          /* 4 pages before the bios, 3 pages for vmx tss pages,
>  			 * the other page for EPT real mode pagetable */
> -                        set_e820_range(ES, regs.u.r16.di, 0xfffbc000L,
> -                                       0xfffc0000L, 0, 0, 2);
> +                        set_e820_range(ES, regs.u.r16.di, 0xfeffc000L,
> +                                       0xff000000L, 0, 0, 2);
>                          regs.u.r32.ebx = 6;

So if you use an older kernel, and the kvm_set_identity_map_addr fails,
you get the e820 entry wrong right? Perhaps you should use the hw/fw_cfg.c 
interface to communicate with the BIOS.


>                          break;
>                      case 6:
> -                        /* 256KB BIOS area at the end of 4 GB */
> +                        /* 16MB BIOS area at the end of 4 GB */
>                          set_e820_range(ES, regs.u.r16.di,
> -                                       0xfffc0000L, 0x00000000L ,0, 0, 2);
> +                                       0xff000000L, 0x00000000L ,0, 0, 2);
>                          if (extra_highbits_memory_size || extra_lowbits_memory_size)
>                              regs.u.r32.ebx = 7;
>                          else
> -- 
> 1.6.0.4
> 
> --
> To unsubscribe from this list: send the line "unsubscribe kvm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2009-07-28 14:41 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-27  0:23 [PATCH 0/3] Allow larger BIOS image Jordan Justen
2009-07-27  0:23 ` [PATCH 1/3] Update BIOS INT15-E820 to allow a " Jordan Justen
2009-07-27  0:23   ` [PATCH 2/3] Move TSS pages " Jordan Justen
2009-07-27  0:23     ` [PATCH 3/3] Move EPT identity mapping " Jordan Justen
2009-07-28 14:40   ` Marcelo Tosatti [this message]
2009-07-28 16:51     ` [PATCH 1/3] Update BIOS INT15-E820 " Jordan Justen
2009-07-28 16:57       ` Marcelo Tosatti
2009-08-03 15:13 ` [PATCH 0/3] Allow " Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090728144034.GA5084@amt.cnet \
    --to=mtosatti@redhat.com \
    --cc=jordan.l.justen@intel.com \
    --cc=kvm@vger.kernel.org \
    --cc=sheng.yang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox