From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: Re: [PATCHv4 2/2] virtio: refactor find_vqs Date: Tue, 28 Jul 2009 17:58:02 +0300 Message-ID: <20090728145801.GA6048@redhat.com> References: <20090726154709.GC21829@redhat.com> <200907281244.32124.rusty@rustcorp.com.au> <20090728143052.GA10365@amit-x200.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Rusty Russell , Christian Borntraeger , virtualization@lists.linux-foundation.org, Anthony Liguori , kvm@vger.kernel.org, avi@redhat.com, Carsten Otte To: Amit Shah Return-path: Received: from mx2.redhat.com ([66.187.237.31]:42201 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750865AbZG1O70 (ORCPT ); Tue, 28 Jul 2009 10:59:26 -0400 Content-Disposition: inline In-Reply-To: <20090728143052.GA10365@amit-x200.redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Tue, Jul 28, 2009 at 08:00:52PM +0530, Amit Shah wrote: > On (Tue) Jul 28 2009 [12:44:31], Rusty Russell wrote: > > On Mon, 27 Jul 2009 01:17:09 am Michael S. Tsirkin wrote: > > > This refactors find_vqs, making it more readable and robust, and fixing > > > two regressions from 2.6.30: > > > - double free_irq causing BUG_ON on device removal > > > - probe failure when vq can't be assigned to msi-x vector > > > (reported on old host kernels) > > > > > > An older version of this patch was tested by Amit Shah. > > > > OK, I've applied both of these; I'd like to see a new test by Amit to > > make sure tho. > > Tested these patches as well. They work fine. > > Tested-by: Amit Shah Amit, thanks very much for the testing. -- MST