From mboxrd@z Thu Jan 1 00:00:00 1970 From: Glauber Costa Subject: Re: [PATCH] exit if we fail to initialize kvm Date: Tue, 28 Jul 2009 18:28:52 -0300 Message-ID: <20090728212852.GY4776@poweredge.glommer> References: <1248814374-7953-1-git-send-email-glommer@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: "kvm@vger.kernel.org" , "avi@redhat.com" To: Alexander Graf Return-path: Received: from mx2.redhat.com ([66.187.237.31]:40748 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755179AbZG1VVz (ORCPT ); Tue, 28 Jul 2009 17:21:55 -0400 Content-Disposition: inline In-Reply-To: Sender: kvm-owner@vger.kernel.org List-ID: On Tue, Jul 28, 2009 at 11:15:19PM +0200, Alexander Graf wrote: > > On 28.07.2009, at 22:52, Glauber Costa wrote: > >> Falling back to tcg has proven to be evil through time. The option is >> to >> do not try to act behind user's back, and quit the program completely >> if >> we fail to initialize kvm. Right now, the only way to run tcg from our >> tree >> becomes explicitly asking for it, with the -no-kvm option. > > Well, actually there's one little difference: I tell the user to use - > no-kvm if he really wants cpu emulation. > > But simply failing is probably good enough. With my patch, we won't fail if the user asked -no-kvm, because then we won't even try to initialize kvm. We only exit here, if we try, but fail