From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joerg Roedel Subject: Re: [PATCH 08/12] kvm/svm: cache nested intercepts Date: Wed, 29 Jul 2009 15:47:38 +0200 Message-ID: <20090729134738.GK18313@amd.com> References: <1248872192-30881-1-git-send-email-joerg.roedel@amd.com> <1248872192-30881-9-git-send-email-joerg.roedel@amd.com> <4A704AFF.8070702@redhat.com> <20090729131319.GF18313@amd.com> <4A704DEA.8040101@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Cc: Alexander Graf , kvm@vger.kernel.org, linux-kernel@vger.kernel.org To: Avi Kivity Return-path: Received: from va3ehsobe004.messaging.microsoft.com ([216.32.180.14]:5789 "EHLO VA3EHSOBE004.bigfish.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755481AbZG2NsD (ORCPT ); Wed, 29 Jul 2009 09:48:03 -0400 Content-Disposition: inline In-Reply-To: <4A704DEA.8040101@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Wed, Jul 29, 2009 at 04:26:02PM +0300, Avi Kivity wrote: > On 07/29/2009 04:13 PM, Joerg Roedel wrote: > >On Wed, Jul 29, 2009 at 04:13:35PM +0300, Avi Kivity wrote: > >>I don't see the benefit of this patch. Accessing the cache is just > >>as expensive as accessing the real vmcb. > > > >The benefit is that we don't have to gup and map the nested vmcb just > >for checking who will take the intercept. > > Makes sense. > > >Another reason is that with > >this patch the behavior of nested SVM is more aligned to real hardware. > > Even more important, please put this in the commit log. Ok, will do.