From mboxrd@z Thu Jan 1 00:00:00 1970 From: Glauber Costa Subject: Re: [PATCH] simplify creation of kernel irqchip and pit Date: Wed, 29 Jul 2009 10:50:00 -0300 Message-ID: <20090729135000.GA4776@poweredge.glommer> References: <1248415027-31313-1-git-send-email-glommer@redhat.com> <4A703A34.2090900@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: kvm@vger.kernel.org To: Avi Kivity Return-path: Received: from mx2.redhat.com ([66.187.237.31]:44950 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932160AbZG2NnA (ORCPT ); Wed, 29 Jul 2009 09:43:00 -0400 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n6TDh0j7009972 for ; Wed, 29 Jul 2009 09:43:00 -0400 Content-Disposition: inline In-Reply-To: <4A703A34.2090900@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Wed, Jul 29, 2009 at 03:01:56PM +0300, Avi Kivity wrote: > On 07/24/2009 08:57 AM, Glauber Costa wrote: >> Creation of those devices can be a lot simpler. In particular, >> if we start by assuming they will be on, and disabling later if >> anything fails (user request counts as failing here), we can remove >> two variables that really serves no reason. >> > > The patch introduces mixed indentation. Please stick with one style or > another. Are you willin go "apply" my patch that changes everything to four spaces? If you are, I'm only resending things after that. > > -- > error compiling committee.c: too many arguments to function >