Re: [PATCH] simplify creation of kernel irqchip and pit

Glauber Costa
2009-07-29T13:43:00Z

On Wed, Jul 29, 2009 at 03:01:56PM +0300, Avi Kivity wrote:
> On 07/24/2009 08:57 AM, Glauber Costa wrote:
>> Creation of those devices can be a lot simpler. In particular,
>> if we start by assuming they will be on, and disabling later if
>> anything fails (user request counts as failing here), we can remove
>> two variables that really serves no reason.
>>
>
> The patch introduces mixed indentation. Please stick with one style or
> another.
Are you willin go "apply" my patch that changes everything to four spaces?
If you are, I'm only resending things after that.
>
> --
> error compiling committee.c: too many arguments to function
>