From: Gleb Natapov <gleb@redhat.com>
To: Avi Kivity <avi@redhat.com>
Cc: Marcelo Tosatti <mtosatti@redhat.com>,
Jan Kiszka <jan.kiszka@web.de>, kvm-devel <kvm@vger.kernel.org>
Subject: Re: [PATCH] KVM: VMX: Fix locking order in handle_invalid_guest_state
Date: Thu, 30 Jul 2009 14:24:07 +0300 [thread overview]
Message-ID: <20090730112407.GN30449@redhat.com> (raw)
In-Reply-To: <4A718360.3040300@redhat.com>
On Thu, Jul 30, 2009 at 02:26:24PM +0300, Avi Kivity wrote:
> On 07/30/2009 02:16 PM, Gleb Natapov wrote:
>>> I think there's little reason now. One thing we need to do is make it
>>> possible to call the injection code twice without entering the guest. I
>>> think right now it assumes nothing has been injected.
>>>
>>>
>> I Looked at this and it seems the current code handle this case.
>> Injection puts an event on a queue and if we haven't entered a guest
>> after this point on the next entry event is injected from the queue,
>> just like if injection failed due to IDT access.
>>
>>
>
> Good (it was one of the goals of the original interrupt rework, ~2 years
> ago)
>
But if we emulate an injection by playing with guest memory and
registers we have to be sure we do it only once.
--
Gleb.
next prev parent reply other threads:[~2009-07-30 11:24 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-22 21:53 [PATCH] KVM: VMX: Fix locking order in handle_invalid_guest_state Jan Kiszka
2009-07-23 21:45 ` Marcelo Tosatti
2009-07-24 7:00 ` Jan Kiszka
2009-07-26 13:51 ` Avi Kivity
2009-07-26 14:23 ` Jan Kiszka
2009-07-26 14:36 ` Avi Kivity
2009-07-26 14:38 ` Jan Kiszka
2009-07-26 14:47 ` Avi Kivity
2009-07-26 14:55 ` Jan Kiszka
2009-07-26 15:02 ` Avi Kivity
2009-07-29 12:24 ` Marcelo Tosatti
2009-07-29 12:44 ` Avi Kivity
2009-07-29 14:07 ` Marcelo Tosatti
2009-07-29 14:32 ` Gleb Natapov
2009-07-30 11:16 ` Avi Kivity
2009-07-30 11:16 ` Gleb Natapov
2009-07-30 11:26 ` Avi Kivity
2009-07-30 11:24 ` Gleb Natapov [this message]
2009-07-30 11:46 ` Avi Kivity
2009-07-30 11:47 ` Gleb Natapov
2009-07-30 11:57 ` Gleb Natapov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090730112407.GN30449@redhat.com \
--to=gleb@redhat.com \
--cc=avi@redhat.com \
--cc=jan.kiszka@web.de \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).