From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gleb Natapov Subject: Re: [PATCH] KVM: VMX: Fix locking order in handle_invalid_guest_state Date: Thu, 30 Jul 2009 14:24:07 +0300 Message-ID: <20090730112407.GN30449@redhat.com> References: <4A678A56.7050901@web.de> <20090723214553.GA10152@amt.cnet> <20090729122456.GA16868@amt.cnet> <4A704424.1090602@redhat.com> <20090729140716.GA18751@amt.cnet> <4A71810E.5010105@redhat.com> <20090730111616.GL30449@redhat.com> <4A718360.3040300@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Marcelo Tosatti , Jan Kiszka , kvm-devel To: Avi Kivity Return-path: Received: from mx2.redhat.com ([66.187.237.31]:42529 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752920AbZG3LYI (ORCPT ); Thu, 30 Jul 2009 07:24:08 -0400 Content-Disposition: inline In-Reply-To: <4A718360.3040300@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Thu, Jul 30, 2009 at 02:26:24PM +0300, Avi Kivity wrote: > On 07/30/2009 02:16 PM, Gleb Natapov wrote: >>> I think there's little reason now. One thing we need to do is make it >>> possible to call the injection code twice without entering the guest. I >>> think right now it assumes nothing has been injected. >>> >>> >> I Looked at this and it seems the current code handle this case. >> Injection puts an event on a queue and if we haven't entered a guest >> after this point on the next entry event is injected from the queue, >> just like if injection failed due to IDT access. >> >> > > Good (it was one of the goals of the original interrupt rework, ~2 years > ago) > But if we emulate an injection by playing with guest memory and registers we have to be sure we do it only once. -- Gleb.