From mboxrd@z Thu Jan  1 00:00:00 1970
From: Gleb Natapov <gleb@redhat.com>
Subject: Re: [PATCH] KVM: VMX: Fix locking order in
	handle_invalid_guest_state
Date: Thu, 30 Jul 2009 14:57:33 +0300
Message-ID: <20090730115733.GP30449@redhat.com>
References: <20090723214553.GA10152@amt.cnet> <20090729122456.GA16868@amt.cnet> <4A704424.1090602@redhat.com> <20090729140716.GA18751@amt.cnet> <4A71810E.5010105@redhat.com> <20090730111616.GL30449@redhat.com> <4A718360.3040300@redhat.com> <20090730112407.GN30449@redhat.com> <4A718833.6030407@redhat.com> <20090730114730.GA6168@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Marcelo Tosatti <mtosatti@redhat.com>,
	Jan Kiszka <jan.kiszka@web.de>, kvm-devel <kvm@vger.kernel.org>
To: Avi Kivity <avi@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx2.redhat.com ([66.187.237.31]:58129 "EHLO mx2.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1753126AbZG3L5e (ORCPT <rfc822;kvm@vger.kernel.org>);
	Thu, 30 Jul 2009 07:57:34 -0400
Content-Disposition: inline
In-Reply-To: <20090730114730.GA6168@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Thu, Jul 30, 2009 at 02:47:30PM +0300, Gleb Natapov wrote:
> On Thu, Jul 30, 2009 at 02:46:59PM +0300, Avi Kivity wrote:
> > On 07/30/2009 02:24 PM, Gleb Natapov wrote:
> >>> Good (it was one of the goals of the original interrupt rework, ~2 years
> >>> ago)
> >>>
> >>>      
> >> But if we emulate an injection by playing with guest memory and
> >> registers we have to be sure we do it only once.
> >>    
> >
> > Once we've successfully updated the stack, inject is complete and we can  
> > remove the interrupt from the queue.
> >
> Then, it we skip actual guest entry for some reason, we will not be
> able to tell if we can inject next irq or not.
> 
Actually thinking about it when first irq is injected we should clear IF
flag, so the second one will not happen.

--
			Gleb.