From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?utf-8?B?SsOhbiBPTkRSRUogKFNBTCk=?= Subject: Re: [PATCH] unbreak booting with virtio Date: Sat, 1 Aug 2009 10:47:15 +0200 Message-ID: <20090801084715.GF2701@salstar.sk> References: <1249064349-799-1-git-send-email-glommer@redhat.com> <20090801070455.GD2701@salstar.sk> <20090801080156.GE2701@salstar.sk> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Glauber Costa , "kvm@vger.kernel.org" , "avi@redhat.com" To: Alexander Graf Return-path: Received: from work.salstar.sk ([158.197.240.41]:39976 "EHLO work.salstar.sk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751887AbZHAIrP (ORCPT ); Sat, 1 Aug 2009 04:47:15 -0400 Content-Disposition: inline In-Reply-To: Sender: kvm-owner@vger.kernel.org List-ID: On Sat, Aug 01, 2009 at 10:19:20AM +0200, Alexander Graf wrote: > > On 01.08.2009, at 10:01, J=C3=A1n ONDREJ (SAL) wrote: > >> On Sat, Aug 01, 2009 at 09:04:55AM +0200, J=C3=A1n ONDREJ (SAL) wrot= e: >>> On Fri, Jul 31, 2009 at 09:55:39PM +0200, Alexander Graf wrote: >>>> >>>> On 31.07.2009, at 20:19, Glauber Costa wrote: >>>> >>>>> cp "$1" "$2" >>>>> +sum=3D$(echo "obase=3D8; $sum" | bc) >>>>> printf "\\$sum" | dd of=3D"$2" bs=3D1 count=3D1 seek=3D$size conv= =3Dnotrunc=20 >>>>> 2>/ >>>>> dev/null >>> >>> May be it's better to use awk: >>> >>> echo $sum | awk '{ printf("%c", $1) }' \ >>> | dd of=3D"$2" bs=3D1 count=3D1 seek=3D$size conv=3Dnotrunc 2>/dev= /null >>> >>> This version accepts decimal $sum, does not need conversion to octa= l. >> >> Ane may be it's better to write whole checksum in awk, it's faster a= nd >> cleaner. See attached patch (I am sorry, I don't know how to use git= -=20 >> email). > > My awk magic is pretty bad, but I think this version is missing the =20 > padding, right? Right. If you prefer this version agains Paolos double printf, I can update it, if not, just use Pauols solution. SAL