Re: [PATCH] unbreak booting with virtio

Alexander Graf
2009-07-31T19:55:22Z

On 31.07.2009, at 20:19, Glauber Costa <glommer@redhat.com> wrote:

> Since commit 89e671e3, extboot is broken due to wrong checksum
>
> The problem is that printf "\\$sum" syntax will require an octal
> representation, so the fix I'm proposing is to convert it first.

Is there no easy way to tell printf we're on decimal? I don't have a
Linux system handy atm, but I thought \90 was in fact a 90.

Either way, my only complaint would be to introduce a dependency on bc.

Alex

>
> Signed-off-by: Glauber Costa <glommer@redhat.com>
> CC: Alexander Graf <agraf@suse.de>
> ---
> pc-bios/optionrom/signrom.sh | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/pc-bios/optionrom/signrom.sh b/pc-bios/optionrom/
> signrom.sh
> index 4322811..3512cc4 100755
> --- a/pc-bios/optionrom/signrom.sh
> +++ b/pc-bios/optionrom/signrom.sh
> @@ -42,4 +42,5 @@ sum=$(( 256 - $sum ))
>
> # and write the output file
> cp "$1" "$2"
> +sum=$(echo "obase=8; $sum" | bc)
> printf "\\$sum" | dd of="$2" bs=1 count=1 seek=$size conv=notrunc 2>/
> dev/null
> --
> 1.6.2.2
>