From: Gleb Natapov <gleb@redhat.com>
To: Avi Kivity <avi@redhat.com>
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
davidel@xmailserver.org, kvm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH-RFC 2/2] eventfd: EFD_STATE flag
Date: Tue, 4 Aug 2009 12:17:55 +0300 [thread overview]
Message-ID: <20090804091755.GD4764@redhat.com> (raw)
In-Reply-To: <4A77FCB8.1000205@redhat.com>
On Tue, Aug 04, 2009 at 12:17:44PM +0300, Avi Kivity wrote:
> On 08/04/2009 11:54 AM, Michael S. Tsirkin wrote:
>> On Tue, Aug 04, 2009 at 11:53:03AM +0300, Avi Kivity wrote:
>>
>>> On 08/03/2009 07:57 PM, Michael S. Tsirkin wrote:
>>>
>>>>> Why not do it at the point of the write?
>>>>>
>>>>> if (value != ctx->count) {
>>>>> ctx->count = value;
>>>>> wake_things_up();
>>>>> }
>>>>>
>>>>>
>>>> What if write comes before read?
>>>>
>>>>
>>> The read will get the new value.
>>>
>>
>> Yes :) But how does read know it should not block?
>>
>
> If a different read comes after the write but after our read, it will
> have transferred the value, resulting in the same situation.
>
> I think reads should never block with a state based mechanism.
>
Reader may want to poll for the status change.
--
Gleb.
next prev parent reply other threads:[~2009-08-04 9:17 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1248803500.git.mst@redhat.com>
2009-07-28 17:54 ` [PATCH-RFC 1/2] eventfd: reorganize the code to simplify new flags Michael S. Tsirkin
2009-07-28 17:55 ` [PATCH-RFC 2/2] eventfd: EFD_STATE flag Michael S. Tsirkin
2009-08-03 15:09 ` Avi Kivity
2009-08-03 15:14 ` Michael S. Tsirkin
2009-08-03 15:29 ` Avi Kivity
2009-08-03 16:57 ` Michael S. Tsirkin
2009-08-04 8:53 ` Avi Kivity
2009-08-04 8:54 ` Michael S. Tsirkin
2009-08-04 9:17 ` Avi Kivity
2009-08-04 9:17 ` Gleb Natapov [this message]
2009-08-04 9:25 ` Avi Kivity
2009-08-04 9:23 ` Gleb Natapov
2009-08-04 9:30 ` Avi Kivity
2009-08-04 9:26 ` Michael S. Tsirkin
2009-08-04 10:06 ` Avi Kivity
2009-08-04 9:33 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090804091755.GD4764@redhat.com \
--to=gleb@redhat.com \
--cc=avi@redhat.com \
--cc=davidel@xmailserver.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).