From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marcelo Tosatti Subject: Re: [PATCH 0/3] PIC fixes Date: Wed, 5 Aug 2009 16:05:02 -0300 Message-ID: <20090805190502.GA6401@amt.cnet> References: <1249389029-12801-1-git-send-email-gleb@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: avi@redhat.com, kvm@vger.kernel.org To: Gleb Natapov Return-path: Received: from mx2.redhat.com ([66.187.237.31]:50572 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752406AbZHETFl (ORCPT ); Wed, 5 Aug 2009 15:05:41 -0400 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n75J5cCH001740 for ; Wed, 5 Aug 2009 15:05:42 -0400 Content-Disposition: inline In-Reply-To: <1249389029-12801-1-git-send-email-gleb@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Tue, Aug 04, 2009 at 03:30:26PM +0300, Gleb Natapov wrote: > Ack notifiers called at wrong time in PIC. kvm_vcpu_kick() can be called > under spinlock now, so code can be simplified. > > Gleb Natapov (3): > Call kvm_vcpu_kick() inside pic spinlock > Call ack notifiers from PIC when guest OS acks an IRQ. > Replace pic_lock()/pic_unlock() with direct call to spinlock > functions. > > arch/x86/kvm/i8259.c | 64 +++++++++++++------------------------------------ > arch/x86/kvm/irq.h | 1 - > 2 files changed, 17 insertions(+), 48 deletions(-) Looks good to me.