* [PATCH] kvm: export kvm_para.h
@ 2009-08-10 12:48 Michael S. Tsirkin
2009-08-16 12:09 ` Avi Kivity
0 siblings, 1 reply; 3+ messages in thread
From: Michael S. Tsirkin @ 2009-08-10 12:48 UTC (permalink / raw)
To: avi, kvm
kvm_para.h contains userspace interface and so
should be exported.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
Avi, this fixes a bug (in build system) that has been there since
2.6.26. Since userspace already uses this header, I think it would be
nice to have the fix in 2.6.31.
include/linux/Kbuild | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/include/linux/Kbuild b/include/linux/Kbuild
index ab93554..598d407 100644
--- a/include/linux/Kbuild
+++ b/include/linux/Kbuild
@@ -267,6 +267,7 @@ unifdef-y += keyboard.h
ifneq ($(wildcard $(srctree)/arch/$(SRCARCH)/include/asm/kvm.h \
$(srctree)/include/asm-$(SRCARCH)/kvm.h),)
unifdef-y += kvm.h
+unifdef-y += kvm_para.h
endif
unifdef-y += llc.h
unifdef-y += loop.h
--
1.6.2.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] kvm: export kvm_para.h
2009-08-10 12:48 [PATCH] kvm: export kvm_para.h Michael S. Tsirkin
@ 2009-08-16 12:09 ` Avi Kivity
2009-08-16 12:11 ` Michael S. Tsirkin
0 siblings, 1 reply; 3+ messages in thread
From: Avi Kivity @ 2009-08-16 12:09 UTC (permalink / raw)
To: Michael S. Tsirkin; +Cc: kvm
On 08/10/2009 03:48 PM, Michael S. Tsirkin wrote:
> kvm_para.h contains userspace interface and so
> should be exported.
>
>
Doesn't it need asm/kvm_para.h as well?
--
error compiling committee.c: too many arguments to function
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] kvm: export kvm_para.h
2009-08-16 12:09 ` Avi Kivity
@ 2009-08-16 12:11 ` Michael S. Tsirkin
0 siblings, 0 replies; 3+ messages in thread
From: Michael S. Tsirkin @ 2009-08-16 12:11 UTC (permalink / raw)
To: Avi Kivity; +Cc: kvm
On Sun, Aug 16, 2009 at 03:09:55PM +0300, Avi Kivity wrote:
> On 08/10/2009 03:48 PM, Michael S. Tsirkin wrote:
>> kvm_para.h contains userspace interface and so
>> should be exported.
>>
>>
>
> Doesn't it need asm/kvm_para.h as well?
Yes, that was v2.
> --
> error compiling committee.c: too many arguments to function
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-08-16 12:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-08-10 12:48 [PATCH] kvm: export kvm_para.h Michael S. Tsirkin
2009-08-16 12:09 ` Avi Kivity
2009-08-16 12:11 ` Michael S. Tsirkin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).